chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm - Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Polishing Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/browser/extensions/external_install_ui.cc ('k') | chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm » ('j') | chrome/browser/ui/views/extensions/extension_install_dialog_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

index 4e69bddcb84ec18dbf684ea7ae1f751749d81881..d7604bb10f07baa1141b94c1095907e419a14dc5 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

@@ -494,10 +494,11 @@ void DrawBulletInFrame(NSRect frame) {

if (prompt.ShouldShowPermissions()) {

NSMutableArray* children = [NSMutableArray array];

- if (prompt.GetPermissionCount() > 0) {

- for (size_t i = 0; i < prompt.GetPermissionCount(); ++i) {

+ if (prompt.GetPermissionCount(false) > 0) {

+ for (size_t i = 0; i < prompt.GetPermissionCount(false); ++i) {

[children addObject:

- [self buildItemWithTitle:SysUTF16ToNSString(prompt.GetPermission(i))

+ [self buildItemWithTitle:SysUTF16ToNSString(

+ prompt.GetPermission(i, false))

isGroupItem:NO

children:nil]];

}