chrome/browser/extensions/external_install_ui.cc - Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_install_ui.cc

Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Polishing Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm » ('j') | chrome/browser/ui/views/extensions/extension_install_dialog_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_install_ui.cc

diff --git a/chrome/browser/extensions/external_install_ui.cc b/chrome/browser/extensions/external_install_ui.cc

index 70f8c9fc7c871fa9c14b0fb2f3533c5b2ea8fd66..17374b2851e2ddf6a4366ff375385fd299870415 100644

--- a/chrome/browser/extensions/external_install_ui.cc

+++ b/chrome/browser/extensions/external_install_ui.cc

@@ -377,12 +377,12 @@ string16 ExternalInstallGlobalError::GetBubbleViewTitle() {

std::vector<string16> ExternalInstallGlobalError::GetBubbleViewMessages() {

std::vector<string16> messages;

messages.push_back(prompt_->GetHeading());

- if (prompt_->GetPermissionCount()) {

+ if (prompt_->GetPermissionCount(false)) {

messages.push_back(prompt_->GetPermissionsHeading());

- for (size_t i = 0; i < prompt_->GetPermissionCount(); ++i) {

+ for (size_t i = 0; i < prompt_->GetPermissionCount(false); ++i) {

messages.push_back(l10n_util::GetStringFUTF16(

IDS_EXTENSION_PERMISSION_LINE,

- prompt_->GetPermission(i)));

+ prompt_->GetPermission(i, false)));

}

// TODO(yoz): OAuth issue advice?