Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1885343002: Adjust the footer layout in ClearBrowsingDataPreferences (Closed)

Created:
4 years, 8 months ago by msramek
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Adjust the footer layout in ClearBrowsingDataPreferences 1. According to the material design specification, the icon in the footer should be aligned with the top of the footer text. However, this does not look correctly, as there is still empty space between the top of the TextView and the actual top of the tallest letter. Therefore, we lower the icon a few pixels to match the ascender line of the font. 2. The default padding of preferences is 16dp. This means that the spacing around the two footer paragraphs is 16dp-32dp-16dp. Our mocks require 16dp-16dp-24dp. We therefore define the default bottom padding to be 24dp, leading to 16dp-40dp-24dp, then remove the bottom padding of the first paragraph, leading to the correct 16dp-16dp-24dp. BUG=602253 Review URL: https://codereview.chromium.org/1872363002 Cr-Commit-Position: refs/heads/master@{#386951} (cherry picked from commit 5301cfa576d36e6d84acd6e2ca33f74047140ed9) Committed: https://chromium.googlesource.com/chromium/src/+/79865a7346184c429005aba0355262951e1f0d3b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2 lines) Patch
M chrome/android/java/res/layout/text_message_with_link_and_icon_preference.xml View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/res/values/attrs.xml View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/android/java/res/xml/clear_browsing_data_preferences.xml View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/TextMessageWithLinkAndIconPreference.java View 4 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
msramek
4 years, 8 months ago (2016-04-14 09:50:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
79865a7346184c429005aba0355262951e1f0d3b.

Powered by Google App Engine
This is Rietveld 408576698