Adjust the footer layout in ClearBrowsingDataPreferences

Adjust the footer layout in ClearBrowsingDataPreferences

1. According to the material design specification, the icon in the footer
   should be aligned with the top of the footer text. However, this does
   not look correctly, as there is still empty space between the top of
   the TextView and the actual top of the tallest letter. Therefore, we
   lower the icon a few pixels to match the ascender line of the font.

2. The default padding of preferences is 16dp. This means that the spacing
   around the two footer paragraphs is 16dp-32dp-16dp. Our mocks require
   16dp-16dp-24dp. We therefore define the default bottom padding to be 24dp,
   leading to 16dp-40dp-24dp, then remove the bottom padding of the first
   paragraph, leading to the correct 16dp-16dp-24dp.

BUG=602253
Committed: https://crrev.com/5301cfa576d36e6d84acd6e2ca33f74047140ed9
Cr-Commit-Position: refs/heads/master@{#386951}

[msramek, 2016-04-11 13:37:14]

msramek@chromium.org changed reviewers:
+ dtrainor@chromium.org

[msramek, 2016-04-11 13:37:14]

Hi David!

Can you please have a look at this?

I would normally sent this to newt@ (who's leaving) or dfalcantara@ (who's OOO),
so I'm picking the next name from the OWNERS file :) But it's a relatively
context-free change.

Thanks!
Martin

[David Trainor- moved to gerrit, 2016-04-12 16:28:38]

lgtm thanks!

[msramek, 2016-04-13 09:03:30]

Thanks, David!

[msramek, 2016-04-13 09:03:32]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2016-04-13 09:03:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1872363002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1872363002/1

[commit-bot: I haz the power, 2016-04-13 09:45:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-13 09:46:45]

Description was changed from

==========
Adjust the footer layout in ClearBrowsingDataPreferences

1. According to the material design specification, the icon in the footer
   should be aligned with the top of the footer text. However, this does
   not look correctly, as there is still empty space between the top of
   the TextView and the actual top of the tallest letter. Therefore, we
   lower the icon a few pixels to match the ascender line of the font.

2. The default padding of preferences is 16dp. This means that the spacing
   around the two footer paragraphs is 16dp-32dp-16dp. Our mocks require
   16dp-16dp-24dp. We therefore define the default bottom padding to be 24dp,
   leading to 16dp-40dp-24dp, then remove the bottom padding of the first
   paragraph, leading to the correct 16dp-16dp-24dp.

BUG=602253
==========

to

==========
Adjust the footer layout in ClearBrowsingDataPreferences

1. According to the material design specification, the icon in the footer
   should be aligned with the top of the footer text. However, this does
   not look correctly, as there is still empty space between the top of
   the TextView and the actual top of the tallest letter. Therefore, we
   lower the icon a few pixels to match the ascender line of the font.

2. The default padding of preferences is 16dp. This means that the spacing
   around the two footer paragraphs is 16dp-32dp-16dp. Our mocks require
   16dp-16dp-24dp. We therefore define the default bottom padding to be 24dp,
   leading to 16dp-40dp-24dp, then remove the bottom padding of the first
   paragraph, leading to the correct 16dp-16dp-24dp.

BUG=602253

Committed: https://crrev.com/5301cfa576d36e6d84acd6e2ca33f74047140ed9
Cr-Commit-Position: refs/heads/master@{#386951}
==========

[commit-bot: I haz the power, 2016-04-13 09:46:46]

Patchset 1 (id:??) landed as
https://crrev.com/5301cfa576d36e6d84acd6e2ca33f74047140ed9
Cr-Commit-Position: refs/heads/master@{#386951}