Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Unified Diff: runtime/observatory/lib/src/elements/code_view.dart

Issue 1885273004: Observatory: Tweak disassembly comments (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/code_view.dart
diff --git a/runtime/observatory/lib/src/elements/code_view.dart b/runtime/observatory/lib/src/elements/code_view.dart
index d8fa1c77223b46a4b0bf38d5c5e5dc4379023178..77ffef58780891a3fe7dde2faccae49cf12c5c0e 100644
--- a/runtime/observatory/lib/src/elements/code_view.dart
+++ b/runtime/observatory/lib/src/elements/code_view.dart
@@ -28,6 +28,8 @@ class CodeViewElement extends ObservatoryElement {
DisassemblyTable disassemblyTable;
InlineTable inlineTable;
+ static const kDisassemblyColumnIndex = 3;
+
CodeViewElement.created() : super.created() {
// Create table models.
var columns = [
@@ -212,7 +214,20 @@ class CodeViewElement extends ObservatoryElement {
element.ref = content;
cell.children = [element];
} else if (content != null) {
- cell.text = content.toString();
+ String text = '$content';
+ if (i == kDisassemblyColumnIndex) {
+ // Disassembly might be a comment. Reduce indentation, change styling,
+ // widen to span next column.
+ if (text.startsWith(' ;;')) {
+ cell.attributes['colspan'] = '2';
+ cell.classes.add('code-comment');
+ text = text.substring(6);
+ } else {
+ cell.attributes['colspan'] = '1';
+ cell.classes.remove('code-comment');
+ }
+ }
+ cell.text = text;
}
}
}
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/code_view.html » ('j') | runtime/observatory/pubspec.yaml » ('J')

Powered by Google App Engine
This is Rietveld 408576698