Observatory: Tweak disassembly comments

runtime/observatory/lib/src/elements/code_view.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library code_view_element;
 
 import 'dart:async';
 import 'dart:html';
 import 'observatory_element.dart';
 import 'service_ref.dart';
@@ skipping 10 matching lines @@
   InlineTable(columns) : super(columns);
 }
 
 @CustomTag('code-view')
 class CodeViewElement extends ObservatoryElement {
   @observable Code code;
   ProfileCode get profile => code == null ? null : code.profile;
   DisassemblyTable disassemblyTable;
   InlineTable inlineTable;
 
+  static const kDisassemblyColumnIndex = 3;
+
   CodeViewElement.created() : super.created() {
     // Create table models.
     var columns = [
         new SortedTableColumn('Address'),
         new SortedTableColumn('Inclusive'),
         new SortedTableColumn('Exclusive'),
         new SortedTableColumn('Disassembly'),
         new SortedTableColumn('Objects'),
     ];
     disassemblyTable = new DisassemblyTable(columns);
@@ skipping 164 matching lines @@
     final row = disassemblyTable.rows[rowIndex];
     final n = row.values.length;
     for (var i = 0; i < n; i++) {
       final cell = tr.children[i];
       final content = row.values[i];
       if (content is ServiceObject) {
         ServiceRefElement element = new Element.tag('any-service-ref');
         element.ref = content;
         cell.children = [element];
       } else if (content != null) {
-        cell.text = content.toString();
+        String text = '$content';
+        if (i == kDisassemblyColumnIndex) {
+          // Disassembly might be a comment. Reduce indentation, change styling,
+          // widen to span next column.
+          if (text.startsWith('        ;;')) {
+            cell.attributes['colspan'] = '2';
+            cell.classes.add('code-comment');
+            text = text.substring(6);
+          } else {
+            cell.attributes['colspan'] = '1';
+            cell.classes.remove('code-comment');
+          }
+        }
+        cell.text = text;
       }
     }
   }
 
   void _updateDisassemblyDOMTable() {
     var tableBody = $['disassemblyTableBody'];
     assert(tableBody != null);
     // Resize DOM table.
     if (tableBody.children.length > disassemblyTable.sortedRows.length) {
       // Shrink the table.
@@ skipping 148 matching lines @@
   }
 
   void mouseOut(Event e, var detail, Node target) {
     var jt = _findJumpTarget(target);
     if (jt == null) {
       return;
     }
     jt.classes.remove('highlight');
   }
 }