Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: scripts/slave/recipe_modules/v8/api.py

Issue 1885273003: V8: Highligh slow tests not marked as slow. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/v8/test_api.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/v8/api.py
diff --git a/scripts/slave/recipe_modules/v8/api.py b/scripts/slave/recipe_modules/v8/api.py
index c3265be0f2c1167d3a38453a4d809a0fbfe95147..70a6b3ebe7206e6613d3c93bba3ff471263bcbd1 100644
--- a/scripts/slave/recipe_modules/v8/api.py
+++ b/scripts/slave/recipe_modules/v8/api.py
@@ -727,8 +727,13 @@ class V8Api(recipe_api.RecipeApi):
# Slowest tests duration summary.
lines = []
for test in output['slowest_tests']:
+ suffix = ''
+ if 'marked_slow' in test and not test['marked_slow']:
tandrii(chromium) 2016/04/14 13:00:46 if not test.get('marked_slow'):
Michael Achenbach 2016/04/14 13:07:56 That has a different meaning. I don't want a * for
tandrii(chromium) 2016/04/14 13:19:11 you are right. Then this is the one: if test.get('
Michael Achenbach 2016/04/14 13:32:01 Done.
+ suffix = ' *'
lines.append(
- '%s %s' %(V8Api.format_duration(test['duration']), test['name']))
+ '%s %s%s' % (V8Api.format_duration(test['duration']),
+ test['name'], suffix))
+
# Slowest tests duration details.
lines.extend(['', 'Details:', ''])
for test in output['slowest_tests']:
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/v8/test_api.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698