Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: BUILD.gn

Issue 1885093002: Re-enable warning 4701 for GN build and some cleanup (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build_overrides/v8.gni") 5 import("//build_overrides/v8.gni")
6 import("//testing/test.gni") 6 import("//testing/test.gni")
7 import("pdfium.gni") 7 import("pdfium.gni")
8 8
9 config("pdfium_config") { 9 config("pdfium_config") {
10 cflags = [] 10 cflags = []
(...skipping 26 matching lines...) Expand all
37 defines += [ "_FX_CPU_=_FX_X64_" ] 37 defines += [ "_FX_CPU_=_FX_X64_" ]
38 cflags += [ "-fPIC" ] 38 cflags += [ "-fPIC" ]
39 } else if (current_cpu == "x86") { 39 } else if (current_cpu == "x86") {
40 defines += [ "_FX_CPU_=_FX_X86_" ] 40 defines += [ "_FX_CPU_=_FX_X86_" ]
41 } 41 }
42 } 42 }
43 43
44 if (is_win) { 44 if (is_win) {
45 cflags += [ 45 cflags += [
46 "/wd4267", 46 "/wd4267",
47 "/wd4701",
48 ] 47 ]
49 } 48 }
50 49
51 if (is_clang || is_posix) { 50 if (is_clang || is_posix) {
52 # TODO(thestig): Fix all instances, remove this, pdfium:29 51 # TODO(thestig): Fix all instances, remove this, pdfium:29
53 cflags += [ "-Wno-sign-compare" ] 52 cflags += [ "-Wno-sign-compare" ]
54 } 53 }
55 54
56 if (is_posix && !is_clang) { # When GCC. 55 if (is_posix && !is_clang) { # When GCC.
57 cflags += [ "-Wno-error=strict-overflow" ] 56 cflags += [ "-Wno-error=strict-overflow" ]
(...skipping 1673 matching lines...) Expand 10 before | Expand all | Expand 10 after
1731 "//v8:v8_libplatform", 1730 "//v8:v8_libplatform",
1732 ] 1731 ]
1733 include_dirs += [ 1732 include_dirs += [
1734 "//v8", 1733 "//v8",
1735 "//v8/include", 1734 "//v8/include",
1736 ] 1735 ]
1737 configs += [ "//v8:external_startup_data" ] 1736 configs += [ "//v8:external_startup_data" ]
1738 } 1737 }
1739 configs += [ ":pdfium_config" ] 1738 configs += [ ":pdfium_config" ]
1740 } 1739 }
OLDNEW
« no previous file with comments | « no previous file | core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698