Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1885063002: [compiler] Remove CompileEvalForDebugging pipeline. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove CompileEvalForDebugging pipeline. This removes one of the duplicated pipeline implementation from the compiler. By now we can reuse the existing CompileForDebugging for all compilations being kicked off for debugging. R=bmeurer@chromium.org Committed: https://crrev.com/3699f902d6247cbb22b487f5bc56ce8066dcd4cb Cr-Commit-Position: refs/heads/master@{#35472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -39 lines) Patch
M src/compiler.cc View 2 chunks +16 lines, -39 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Michael Starzinger
Benedikt: PTAL. Yang: FYI.
4 years, 8 months ago (2016-04-13 17:13:27 UTC) #3
Benedikt Meurer
Lovely! LGTM
4 years, 8 months ago (2016-04-14 04:20:48 UTC) #4
Yang
lgtm
4 years, 8 months ago (2016-04-14 07:55:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885063002/1
4 years, 8 months ago (2016-04-14 08:05:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 08:07:40 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 08:08:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3699f902d6247cbb22b487f5bc56ce8066dcd4cb
Cr-Commit-Position: refs/heads/master@{#35472}

Powered by Google App Engine
This is Rietveld 408576698