Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: src/compiler.cc

Issue 1885063002: [compiler] Remove CompileEvalForDebugging pipeline. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index 9cec9f3aadd82dd39697485e9997827d7e230108..bed3149394761aa954b97e6554380a89d49a7efb 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -935,44 +935,6 @@ MaybeHandle<Code> GetLazyCode(Handle<JSFunction> function) {
}
-bool CompileEvalForDebugging(Handle<JSFunction> function,
- Handle<SharedFunctionInfo> shared) {
- Handle<Script> script(Script::cast(shared->script()));
- Handle<Context> context(function->context());
-
- Zone zone(function->GetIsolate()->allocator());
- ParseInfo parse_info(&zone, script);
- CompilationInfo info(&parse_info, Handle<JSFunction>::null());
- Isolate* isolate = info.isolate();
-
- parse_info.set_eval();
- parse_info.set_context(context);
- if (context->IsNativeContext()) parse_info.set_global();
- parse_info.set_toplevel();
- parse_info.set_allow_lazy_parsing(false);
- parse_info.set_language_mode(shared->language_mode());
- parse_info.set_parse_restriction(NO_PARSE_RESTRICTION);
- info.MarkAsDebug();
-
- VMState<COMPILER> state(info.isolate());
-
- if (!Parser::ParseStatic(&parse_info)) {
- isolate->clear_pending_exception();
- return false;
- }
-
- FunctionLiteral* lit = parse_info.literal();
- LiveEditFunctionTracker live_edit_tracker(isolate, lit);
-
- if (!CompileUnoptimizedCode(&info)) {
- isolate->clear_pending_exception();
- return false;
- }
- shared->ReplaceCode(*info.code());
- return true;
-}
-
-
bool CompileForDebugging(CompilationInfo* info) {
info->MarkAsDebug();
if (GetUnoptimizedCode(info).is_null()) {
@@ -1186,7 +1148,22 @@ bool Compiler::CompileOptimized(Handle<JSFunction> function,
bool Compiler::CompileDebugCode(Handle<JSFunction> function) {
Handle<SharedFunctionInfo> shared(function->shared());
if (IsEvalToplevel(shared)) {
- return CompileEvalForDebugging(function, shared);
+ Handle<Script> script(Script::cast(shared->script()));
+ Handle<Context> context(function->context());
+
+ Zone zone(function->GetIsolate()->allocator());
+ ParseInfo parse_info(&zone, script);
+ CompilationInfo info(&parse_info, Handle<JSFunction>::null());
+
+ parse_info.set_eval();
+ parse_info.set_context(context);
+ parse_info.set_shared_info(shared);
+ if (context->IsNativeContext()) parse_info.set_global();
+ parse_info.set_toplevel();
+ parse_info.set_allow_lazy_parsing(false);
+ parse_info.set_language_mode(shared->language_mode());
+ parse_info.set_parse_restriction(NO_PARSE_RESTRICTION);
+ return CompileForDebugging(&info);
} else {
CompilationInfoWithZone info(function);
return CompileForDebugging(&info);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698