Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1885023002: Set GpuPreferences correctly in GpuDataManagerImplPrivate::AppendGpuCommandLine. (Closed)

Created:
4 years, 8 months ago by Peng
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Set GpuPreferences correctly in GpuDataManagerImplPrivate::AppendGpuCommandLine. GpuDataManagerImplPrivate::AppendGpuCommandLine() may add some GPU command line switches which have been replaced by GpuPreferences. So we need set those preferences in GpuDataManagerImplPrivate::AppendGpuCommandLine() to allow GPU process get the correct GpuPreferences via IPC message. BUG=601647 Review URL: https://codereview.chromium.org/1881463002 Cr-Commit-Position: refs/heads/master@{#386669} (cherry picked from commit 4c901e8f2249a4efacb311d0e24d09f3c88c8e0c) Committed: https://chromium.googlesource.com/chromium/src/+/dd9653eced19e3ade9b042631cb8f4488bb5d834

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -17 lines) Patch
M content/browser/gpu/gpu_data_manager_impl.h View 2 chunks +6 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 4 chunks +14 lines, -4 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Peng
4 years, 8 months ago (2016-04-13 15:17:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dd9653eced19e3ade9b042631cb8f4488bb5d834.

Powered by Google App Engine
This is Rietveld 408576698