content/browser/gpu/gpu_data_manager_impl_private_unittest.cc - Issue 1885023002: Set GpuPreferences correctly in GpuDataManagerImplPrivate::AppendGpuCommandLine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

Issue 1885023002: Set GpuPreferences correctly in GpuDataManagerImplPrivate::AppendGpuCommandLine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

diff --git a/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc b/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

index a9a189d271a06fa18599f0dac7c6fc50f1d1056a..c92f37cbf43865b7b516ae95c4a89cee8f56a803 100644

--- a/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

+++ b/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

@@ -642,7 +642,7 @@ TEST_F(GpuDataManagerImplPrivateTest, GpuDriverBugListSingle) {

manager->gpu_driver_bugs_.insert(5);

base::CommandLine command_line(0, NULL);

- manager->AppendGpuCommandLine(&command_line);

+ manager->AppendGpuCommandLine(&command_line, nullptr);

EXPECT_TRUE(command_line.HasSwitch(switches::kGpuDriverBugWorkarounds));

std::string args = command_line.GetSwitchValueASCII(

@@ -656,7 +656,7 @@ TEST_F(GpuDataManagerImplPrivateTest, GpuDriverBugListMultiple) {

manager->gpu_driver_bugs_.insert(7);

base::CommandLine command_line(0, NULL);

- manager->AppendGpuCommandLine(&command_line);

+ manager->AppendGpuCommandLine(&command_line, nullptr);

EXPECT_TRUE(command_line.HasSwitch(switches::kGpuDriverBugWorkarounds));

std::string args = command_line.GetSwitchValueASCII(

« no previous file with comments | « content/browser/gpu/gpu_data_manager_impl_private.cc ('k') | content/browser/gpu/gpu_process_host.h » ('j') | no next file with comments »