net/websockets/websocket_basic_handshake_stream.h - Issue 1884943003: HttpStreamParser: Don't reuse sockets which receive unparsed data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/websockets/websocket_basic_handshake_stream.h

Issue 1884943003: HttpStreamParser: Don't reuse sockets which receive unparsed data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix drainer test ('True' means closed...) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/websockets/websocket_basic_handshake_stream.h

diff --git a/net/websockets/websocket_basic_handshake_stream.h b/net/websockets/websocket_basic_handshake_stream.h

index d39098278f22aa92e1bf5825abca63300358c8e6..a4c7b651b9104bf8d5303d072d30b9b816926ac2 100644

--- a/net/websockets/websocket_basic_handshake_stream.h

+++ b/net/websockets/websocket_basic_handshake_stream.h

@@ -66,7 +66,8 @@ class NET_EXPORT_PRIVATE WebSocketBasicHandshakeStream

bool GetRemoteEndpoint(IPEndPoint* endpoint) override;

Error GetSignedEKMForTokenBinding(crypto::ECPrivateKey* key,

std::vector<uint8_t>* out) override;

- void Drain(HttpNetworkSession* session) override;

+ void Drain(HttpNetworkSession* session,

+ scoped_ptr<HttpResponseInfo> response_info) override;

void SetPriority(RequestPriority priority) override;

void PopulateNetErrorDetails(NetErrorDetails* details) override;

UploadProgress GetUploadProgress() const override;

« net/http/http_stream.h ('K') | « net/url_request/url_request_http_job_unittest.cc ('k') | net/websockets/websocket_basic_handshake_stream.cc » ('j') | no next file with comments »