Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: net/websockets/websocket_basic_handshake_stream.cc

Issue 1884943003: HttpStreamParser: Don't reuse sockets which receive unparsed data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix drainer test ('True' means closed...) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/websockets/websocket_basic_handshake_stream.cc
diff --git a/net/websockets/websocket_basic_handshake_stream.cc b/net/websockets/websocket_basic_handshake_stream.cc
index aee33673f00101f7e7b22b81f11c4a7de53cbd1c..a61a9437e5fd3220843c6bcff0ff57c4f9ad328a 100644
--- a/net/websockets/websocket_basic_handshake_stream.cc
+++ b/net/websockets/websocket_basic_handshake_stream.cc
@@ -31,6 +31,7 @@
#include "net/http/http_request_info.h"
#include "net/http/http_response_body_drainer.h"
#include "net/http/http_response_headers.h"
+#include "net/http/http_response_info.h"
#include "net/http/http_status_code.h"
#include "net/http/http_stream_parser.h"
#include "net/socket/client_socket_handle.h"
@@ -451,10 +452,10 @@ Error WebSocketBasicHandshakeStream::GetSignedEKMForTokenBinding(
return ERR_NOT_IMPLEMENTED;
}
-void WebSocketBasicHandshakeStream::Drain(HttpNetworkSession* session) {
- HttpResponseBodyDrainer* drainer = new HttpResponseBodyDrainer(this);
- drainer->Start(session);
- // |drainer| will delete itself.
+void WebSocketBasicHandshakeStream::Drain(
+ HttpNetworkSession* session,
+ scoped_ptr<HttpResponseInfo> response_info) {
+ NOTREACHED();
}
void WebSocketBasicHandshakeStream::SetPriority(RequestPriority priority) {
« net/http/http_stream.h ('K') | « net/websockets/websocket_basic_handshake_stream.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698