Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1884893002: Use WTF::String and WTF::Vector in state machine tests (Closed)

Created:
4 years, 8 months ago by yosin_UTC9
Modified:
4 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use WTF::String and WTF::Vector in state machine tests THis patch replaces |std::string| and |std::vector| usage to |WTF::String| and |WTF::Vector| in "BackwardGraphemeBoundaryStateMachineTest.cpp" and "ForwardGraphemeBoundaryStateMachineTest.cpp". THis patch is follow up of crrev.com/1857633002 BUG=594923 TEST=n/a; no behavior changes Committed: https://crrev.com/9107fc9d20437051ab0f6ba948458ea53bc2e24e Cr-Commit-Position: refs/heads/master@{#386925}

Patch Set 1 #

Total comments: 1

Patch Set 2 : 2016-04-13T14:42:37 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -319 lines) Patch
M third_party/WebKit/Source/core/editing/state_machines/BackwardGraphemeBoundaryStateMachineTest.cpp View 1 4 chunks +96 lines, -88 lines 0 comments Download
M third_party/WebKit/Source/core/editing/state_machines/ForwardGraphemeBoundaryStateMachineTest.cpp View 1 3 chunks +180 lines, -181 lines 0 comments Download
M third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.h View 1 1 chunk +45 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.cpp View 2 chunks +28 lines, -28 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
yosin_UTC9
PTAL
4 years, 8 months ago (2016-04-13 05:24:03 UTC) #3
tkent
https://codereview.chromium.org/1884893002/diff/1/third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.h File third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.h (right): https://codereview.chromium.org/1884893002/diff/1/third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.h#newcode17 third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.h:17: WTF_MAKE_NONCOPYABLE(GraphemeStateMachineTestBase); Can you use DISALLOW_COPY_AND_ASSIGN() from base/macros.h? WebKit/Source/DEPS allows ...
4 years, 8 months ago (2016-04-13 05:31:55 UTC) #4
yosin_UTC9
On 2016/04/13 at 05:31:55, tkent wrote: > https://codereview.chromium.org/1884893002/diff/1/third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.h > File third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.h (right): > > https://codereview.chromium.org/1884893002/diff/1/third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.h#newcode17 ...
4 years, 8 months ago (2016-04-13 05:46:07 UTC) #5
tkent
lgtm
4 years, 8 months ago (2016-04-13 05:49:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884893002/20001
4 years, 8 months ago (2016-04-13 06:13:47 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 06:52:30 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 06:53:46 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9107fc9d20437051ab0f6ba948458ea53bc2e24e
Cr-Commit-Position: refs/heads/master@{#386925}

Powered by Google App Engine
This is Rietveld 408576698