Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.h

Issue 1884893002: Use WTF::String and WTF::Vector in state machine tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: 2016-04-13T14:42:37 Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.h
diff --git a/third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.h b/third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.h
index 8ad1d34b121ff2301cfe1eb7a75702a9beddafc8..d4a6e83b9331aad015a0b2afd00b5fdd3a6c75ab 100644
--- a/third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.h
+++ b/third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.h
@@ -2,33 +2,56 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "base/macros.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "wtf/Vector.h"
#include "wtf/text/Unicode.h"
-
-#include <string>
-#include <vector>
+#include "wtf/text/WTFString.h"
namespace blink {
class BackwardGraphemeBoundaryStateMachine;
class ForwardGraphemeBoundaryStateMachine;
-// Processes the |machine| with preceding/following code points.
-// The result string represents the output sequence of the state machine.
-// Each character represents returned state of each action.
-// I : Invalid
-// R : NeedMoreCodeUnit (Repeat)
-// S : NeedFollowingCodeUnit (Switch)
-// F : Finished
-//
-// For example, if a state machine returns following sequence:
-// NeedMoreCodeUnit, NeedFollowingCodeUnit, Finished
-// the returned string will be "RSF".
-std::string processSequenceBackward(
- BackwardGraphemeBoundaryStateMachine*,
- const std::vector<UChar32>& preceding);
-
-std::string processSequenceForward(
- ForwardGraphemeBoundaryStateMachine*,
- const std::vector<UChar32>& preceding,
- const std::vector<UChar32>& following);
+class GraphemeStateMachineTestBase : public ::testing::Test {
+protected:
+ GraphemeStateMachineTestBase() = default;
+ ~GraphemeStateMachineTestBase() override = default;
+
+ Vector<UChar32> asCodePoints() { return Vector<UChar32>(); }
+
+ template <typename ... Args>
+ Vector<UChar32> asCodePoints(Args... args)
+ {
+ UChar32 codePoints[] = {args...};
+ Vector<UChar32> result(sizeof...(args));
+ for (size_t index = 0; index < sizeof...(args); ++index)
+ result[index] = codePoints[index];
+ return result;
+ }
+
+ // Processes the |machine| with preceding/following code points.
+ // The result string represents the output sequence of the state machine.
+ // Each character represents returned state of each action.
+ // I : Invalid
+ // R : NeedMoreCodeUnit (Repeat)
+ // S : NeedFollowingCodeUnit (Switch)
+ // F : Finished
+ //
+ // For example, if a state machine returns following sequence:
+ // NeedMoreCodeUnit, NeedFollowingCodeUnit, Finished
+ // the returned string will be "RSF".
+ String processSequenceBackward(
+ BackwardGraphemeBoundaryStateMachine*,
+ const Vector<UChar32>& preceding);
+
+ String processSequenceForward(
+ ForwardGraphemeBoundaryStateMachine*,
+ const Vector<UChar32>& preceding,
+ const Vector<UChar32>& following);
+
+private:
+ DISALLOW_COPY_AND_ASSIGN(GraphemeStateMachineTestBase);
+};
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698