Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1884873008: Add libxdiff library (Closed)

Created:
4 years, 8 months ago by Petr Hosek
Modified:
4 years, 8 months ago
Reviewers:
bradnelson, bradn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/third_party.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Add libxdiff library The sources are taken from Git revision aa3a2c2, which is a modified version of the original LibXDiff developed as a part of XMail. R=bradnelson@chromium.org, bradnelson@google.com Committed: https://chromium.googlesource.com/native_client/src/third_party/+/8da76407d39a90d3b9c3418e21d38df67fef8892

Patch Set 1 #

Patch Set 2 : Use correct compiler flags #

Patch Set 3 : Add license and README #

Patch Set 4 : Add license and README #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4295 lines, -0 lines) Patch
A xdiff/BUILD.gn View 1 1 chunk +31 lines, -0 lines 0 comments Download
A xdiff/COPYING View 1 2 3 1 chunk +504 lines, -0 lines 0 comments Download
A xdiff/README View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A xdiff/xdiff.h View 1 chunk +138 lines, -0 lines 0 comments Download
A xdiff/xdiffi.h View 1 chunk +64 lines, -0 lines 0 comments Download
A xdiff/xdiffi.c View 1 chunk +612 lines, -0 lines 0 comments Download
A xdiff/xemit.h View 1 chunk +36 lines, -0 lines 0 comments Download
A xdiff/xemit.c View 1 chunk +267 lines, -0 lines 0 comments Download
A xdiff/xhistogram.c View 1 chunk +363 lines, -0 lines 0 comments Download
A xdiff/xinclude.h View 1 chunk +42 lines, -0 lines 0 comments Download
A xdiff/xmacros.h View 1 chunk +54 lines, -0 lines 0 comments Download
A xdiff/xmerge.c View 1 chunk +686 lines, -0 lines 0 comments Download
A xdiff/xpatience.c View 1 chunk +358 lines, -0 lines 0 comments Download
A xdiff/xprepare.h View 1 chunk +34 lines, -0 lines 0 comments Download
A xdiff/xprepare.c View 1 chunk +483 lines, -0 lines 0 comments Download
A xdiff/xtypes.h View 1 chunk +67 lines, -0 lines 0 comments Download
A xdiff/xutils.h View 1 chunk +47 lines, -0 lines 0 comments Download
A xdiff/xutils.c View 1 chunk +495 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
Petr Hosek
4 years, 8 months ago (2016-04-14 20:42:00 UTC) #1
bradnelson
Can you add a README + license info similar to other projects? go/thirdparty
4 years, 8 months ago (2016-04-14 21:06:07 UTC) #2
Petr Hosek
Done.
4 years, 8 months ago (2016-04-14 21:33:38 UTC) #3
bradnelson
lgtm
4 years, 8 months ago (2016-04-14 23:05:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884873008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884873008/40001
4 years, 8 months ago (2016-04-14 23:05:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: nacl-mac_arm_newlib_opt on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_arm_newlib_opt/builds/323) nacl-mac_glibc_opt on tryserver.nacl (JOB_FAILED, ...
4 years, 8 months ago (2016-04-14 23:06:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884873008/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884873008/90001
4 years, 8 months ago (2016-04-15 01:14:23 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: nacl-presubmit on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/nacl-presubmit/builds/726)
4 years, 8 months ago (2016-04-15 01:16:55 UTC) #15
bradn
lgtm
4 years, 8 months ago (2016-04-15 01:41:47 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884873008/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884873008/90001
4 years, 8 months ago (2016-04-15 01:41:50 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: nacl-presubmit on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/nacl-presubmit/builds/728)
4 years, 8 months ago (2016-04-15 01:44:01 UTC) #21
Petr Hosek
4 years, 8 months ago (2016-04-15 02:26:39 UTC) #23
Message was sent while issue was closed. 
Committed patchset #4 (id:90001) manually as
8da76407d39a90d3b9c3418e21d38df67fef8892.

Powered by Google App Engine
This is Rietveld 408576698