Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1884663002: Bump the min-supported OS version in the installer. (Closed)

Created:
4 years, 8 months ago by grt (UTC plus 2)
Modified:
4 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bump the min-supported OS version in the installer. BUG=602655 Committed: https://crrev.com/0d7a972e9b8f1d8031fa9b59c1723abf2fe1c612 Cr-Commit-Position: refs/heads/master@{#386753}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/setup_main.cc View 1 chunk +2 lines, -2 lines 2 comments Download
M chrome/installer/util/install_util.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
grt (UTC plus 2)
PTAL
4 years, 8 months ago (2016-04-12 16:36:16 UTC) #2
scottmg
lgtm https://codereview.chromium.org/1884663002/diff/1/chrome/installer/setup/setup_main.cc File chrome/installer/setup/setup_main.cc (right): https://codereview.chromium.org/1884663002/diff/1/chrome/installer/setup/setup_main.cc#newcode1739 chrome/installer/setup/setup_main.cc:1739: LOG(ERROR) << "Chrome only supports Windows 7 or ...
4 years, 8 months ago (2016-04-12 17:32:40 UTC) #3
grt (UTC plus 2)
Thanks for the quick turnaround. https://codereview.chromium.org/1884663002/diff/1/chrome/installer/setup/setup_main.cc File chrome/installer/setup/setup_main.cc (right): https://codereview.chromium.org/1884663002/diff/1/chrome/installer/setup/setup_main.cc#newcode1739 chrome/installer/setup/setup_main.cc:1739: LOG(ERROR) << "Chrome only ...
4 years, 8 months ago (2016-04-12 17:58:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884663002/1
4 years, 8 months ago (2016-04-12 17:59:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 18:45:47 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 18:47:35 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0d7a972e9b8f1d8031fa9b59c1723abf2fe1c612
Cr-Commit-Position: refs/heads/master@{#386753}

Powered by Google App Engine
This is Rietveld 408576698