Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5340)

Unified Diff: chrome/renderer/spellchecker/spellcheck_provider.h

Issue 1884583003: Create a spellcheck component that will allow any embedder to reuse common functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviewers' comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/spellchecker/spellcheck_provider.h
diff --git a/chrome/renderer/spellchecker/spellcheck_provider.h b/chrome/renderer/spellchecker/spellcheck_provider.h
index 13d8a2b9e6bd580f33f10c5ee144aec9eb1d8fa1..1a6088bbd83ddd90fafbdb4d409ee5b6a92faa33 100644
--- a/chrome/renderer/spellchecker/spellcheck_provider.h
+++ b/chrome/renderer/spellchecker/spellcheck_provider.h
@@ -18,8 +18,11 @@
class RenderView;
class SpellCheck;
+
+namespace spellcheck {
class SpellCheckMarker;
struct SpellCheckResult;
+}
namespace blink {
class WebString;
@@ -45,7 +48,7 @@ class SpellCheckProvider
void RequestTextChecking(
const base::string16& text,
blink::WebTextCheckingCompletion* completion,
- const std::vector<SpellCheckMarker>& markers);
+ const std::vector<spellcheck::SpellCheckMarker>& markers);
// The number of ongoing IPC requests.
size_t pending_text_request_size() const {
@@ -98,7 +101,7 @@ class SpellCheckProvider
int identifier,
bool succeeded,
const base::string16& text,
- const std::vector<SpellCheckResult>& results);
+ const std::vector<spellcheck::SpellCheckResult>& results);
#endif
// Returns whether |text| has word characters, i.e. whether a spellchecker
@@ -110,7 +113,7 @@ class SpellCheckProvider
void OnRespondTextCheck(
int identifier,
const base::string16& line,
- const std::vector<SpellCheckResult>& results);
+ const std::vector<spellcheck::SpellCheckResult>& results);
void OnToggleSpellPanel(bool is_currently_visible);
#endif
« no previous file with comments | « chrome/renderer/spellchecker/spellcheck_multilingual_unittest.cc ('k') | chrome/renderer/spellchecker/spellcheck_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698