chrome/renderer/spellchecker/spellcheck_provider.cc - Issue 1884583003: Create a spellcheck component that will allow any embedder to reuse common functionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/spellchecker/spellcheck_provider.cc

Issue 1884583003: Create a spellcheck component that will allow any embedder to reuse common functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviewers' comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/spellchecker/spellcheck_provider.h ('k') | chrome/renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/spellchecker/spellcheck_provider.cc

diff --git a/chrome/renderer/spellchecker/spellcheck_provider.cc b/chrome/renderer/spellchecker/spellcheck_provider.cc

index 576460e8dbe025b12abf2170c26ccb7e76a7883e..95573e0da346b42dc116458b4fb8988a2fac724d 100644

--- a/chrome/renderer/spellchecker/spellcheck_provider.cc

+++ b/chrome/renderer/spellchecker/spellcheck_provider.cc

@@ -7,11 +7,11 @@

#include "base/command_line.h"

#include "base/metrics/histogram.h"

#include "chrome/common/chrome_switches.h"

-#include "chrome/common/spellcheck_marker.h"

-#include "chrome/common/spellcheck_messages.h"

-#include "chrome/common/spellcheck_result.h"

#include "chrome/renderer/spellchecker/spellcheck.h"

#include "chrome/renderer/spellchecker/spellcheck_language.h"

+#include "components/spellcheck/common/spellcheck_marker.h"

+#include "components/spellcheck/common/spellcheck_messages.h"

+#include "components/spellcheck/common/spellcheck_result.h"

#include "content/public/renderer/render_view.h"

#include "third_party/WebKit/public/platform/WebVector.h"

#include "third_party/WebKit/public/web/WebDocument.h"

@@ -29,6 +29,8 @@ using blink::WebTextCheckingCompletion;

using blink::WebTextCheckingResult;

using blink::WebTextDecorationType;

using blink::WebVector;

+using spellcheck::SpellCheckMarker;

+using spellcheck::SpellCheckResult;

static_assert(int(blink::WebTextDecorationTypeSpelling) ==

int(SpellCheckResult::SPELLING), "mismatching enums");