Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1884503003: GN: Replace vector<ParseNode*> with vector<unique_ptr<ParseNode>> in parse_tree.h. (Closed)

Created:
4 years, 8 months ago by jbroman
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Replace vector<ParseNode*> with vector<unique_ptr<ParseNode>> in parse_tree.h. Chromium can now use std::unique_ptr. BUG=602726 Committed: https://crrev.com/6ce99c7025ebaca2747f659da3700a388f627919 Cr-Commit-Position: refs/heads/master@{#387958}

Patch Set 1 #

Patch Set 2 : remove comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -45 lines) Patch
M tools/gn/command_format.cc View 13 chunks +21 lines, -18 lines 0 comments Download
M tools/gn/function_foreach.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M tools/gn/function_forward_variables_from.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/functions.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/parse_tree.h View 1 4 chunks +10 lines, -8 lines 0 comments Download
M tools/gn/parse_tree.cc View 7 chunks +13 lines, -11 lines 0 comments Download
M tools/gn/parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jbroman
Unfortunately unique_ptr can be somewhat more verbose (a bunch of ".get()" being added is half ...
4 years, 8 months ago (2016-04-12 19:02:47 UTC) #2
brettw
lgtm
4 years, 8 months ago (2016-04-18 17:37:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884503003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884503003/20001
4 years, 8 months ago (2016-04-18 17:38:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-18 18:18:01 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 18:20:00 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6ce99c7025ebaca2747f659da3700a388f627919
Cr-Commit-Position: refs/heads/master@{#387958}

Powered by Google App Engine
This is Rietveld 408576698