tools/gn/functions.cc - Issue 1884503003: GN: Replace vector<ParseNode*> with vector<unique_ptr<ParseNode>> in parse_tree.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/functions.cc

Issue 1884503003: GN: Replace vector<ParseNode*> with vector<unique_ptr<ParseNode>> in parse_tree.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/functions.cc

diff --git a/tools/gn/functions.cc b/tools/gn/functions.cc

index f6d405d0a56440d5f4a3abae6346fe10af0c69f7..af413d655b3cc33ecb4f8e79dc1c5a8f5f87703b 100644

--- a/tools/gn/functions.cc

+++ b/tools/gn/functions.cc

@@ -464,7 +464,7 @@ Value RunDefined(Scope* scope,

const FunctionCallNode* function,

const ListNode* args_list,

Err* err) {

- const std::vector<const ParseNode*>& args_vector = args_list->contents();

+ const auto& args_vector = args_list->contents();

if (args_vector.size() != 1) {

*err = Err(function, "Wrong number of arguments to defined().",

"Expecting exactly one.");

« no previous file with comments | « tools/gn/function_forward_variables_from.cc ('k') | tools/gn/parse_tree.h » ('j') | no next file with comments »