Move profile handling code to a child class of SharedPageState

Move profile handling code to a child class of SharedPageState

There will be a separate review for removing this logic from SharedPageState.
More info: https://codereview.chromium.org/1871033002/

BUG=603121
Committed: https://crrev.com/70390020b54d46b4d34f96429c1db62b1f0629c4
Cr-Commit-Position: refs/heads/master@{#386943}

Committed: https://crrev.com/7a99b2a7e905842c5ac80617ef666aff8459d541
Cr-Commit-Position: refs/heads/master@{#387697}

[gurrrik, 2016-04-12 10:04:08]

Description was changed from

==========
Move profile handling code to a child class of SharedPageState

There will be a separate review for removing this logic from SharedPageState.
More info: https://codereview.chromium.org/1871033002/

BUG=
==========

to

==========
Move profile handling code to a child class of SharedPageState

There will be a separate review for removing this logic from SharedPageState.
More info: https://codereview.chromium.org/1871033002/

BUG=
==========

[gurrrik, 2016-04-12 10:04:09]

gurrrik@yandex-team.ru changed reviewers:
+ eakuefner@chromium.org

[gurrrik, 2016-04-12 10:04:43]

On 2016/04/12 10:04:09, gurrrik wrote:
> mailto:gurrrik@yandex-team.ru changed reviewers:
> + mailto:eakuefner@chromium.org

Please take a look.

[eakuefner, 2016-04-12 17:27:21]

lgtm, thanks a lot for doing this cleanup!

It looks like this includes your unzip fix; probably you can just close the
other CL, or use it to remove the code in shared_page_state instead.

[eakuefner, 2016-04-12 18:13:23]

Actually, you'll need to make a small change so that this will pass the CQ.

https://codereview.chromium.org/1884493002/diff/1/tools/perf/page_sets/pregen...
File tools/perf/page_sets/pregenerated_profile_shared_state.py (right):

https://codereview.chromium.org/1884493002/diff/1/tools/perf/page_sets/pregen...
tools/perf/page_sets/pregenerated_profile_shared_state.py:126:
saved_output_profile = finder_options.output_profile_path
Since https://codereview.chromium.org/1874473006 has landed just now you'll want
to change this to finder_options.browser_options.output_profile_path

https://codereview.chromium.org/1884493002/diff/1/tools/perf/page_sets/pregen...
tools/perf/page_sets/pregenerated_profile_shared_state.py:130:
finder_options.output_profile_path = final_profile
and here

https://codereview.chromium.org/1884493002/diff/1/tools/perf/page_sets/pregen...
tools/perf/page_sets/pregenerated_profile_shared_state.py:138:
finder_options.output_profile_path = saved_output_profile
and here

[gurrrik, 2016-04-13 07:35:51]

The CQ bit was checked by gurrrik@yandex-team.ru

[gurrrik, 2016-04-13 07:35:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/1884493002/#ps20001
(title: "output_profile_path is in browser_options now")

[commit-bot: I haz the power, 2016-04-13 07:36:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1884493002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1884493002/20001

[gurrrik, 2016-04-13 07:43:54]

On 2016/04/12 17:27:21, eakuefner wrote:
> lgtm, thanks a lot for doing this cleanup!
> 
> It looks like this includes your unzip fix; probably you can just close the
> other CL, or use it to remove the code in shared_page_state instead.

Thanks for reviewing it!

I think I'll use that other CL to remove the code.

[commit-bot: I haz the power, 2016-04-13 09:14:45]

Description was changed from

==========
Move profile handling code to a child class of SharedPageState

There will be a separate review for removing this logic from SharedPageState.
More info: https://codereview.chromium.org/1871033002/

BUG=
==========

to

==========
Move profile handling code to a child class of SharedPageState

There will be a separate review for removing this logic from SharedPageState.
More info: https://codereview.chromium.org/1871033002/

BUG=
==========

[commit-bot: I haz the power, 2016-04-13 09:14:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-13 09:15:52]

Description was changed from

==========
Move profile handling code to a child class of SharedPageState

There will be a separate review for removing this logic from SharedPageState.
More info: https://codereview.chromium.org/1871033002/

BUG=
==========

to

==========
Move profile handling code to a child class of SharedPageState

There will be a separate review for removing this logic from SharedPageState.
More info: https://codereview.chromium.org/1871033002/

BUG=

Committed: https://crrev.com/70390020b54d46b4d34f96429c1db62b1f0629c4
Cr-Commit-Position: refs/heads/master@{#386943}
==========

[commit-bot: I haz the power, 2016-04-13 09:15:52]

Patchset 2 (id:??) landed as
https://crrev.com/70390020b54d46b4d34f96429c1db62b1f0629c4
Cr-Commit-Position: refs/heads/master@{#386943}

[rnephew (Reviews Here), 2016-04-13 20:17:41]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1879193005/ by rnephew@chromium.org.

The reason for reverting is: Breaks startup tests.
crbug.com/603121.

[gurrrik, 2016-04-15 10:12:54]

Description was changed from

==========
Move profile handling code to a child class of SharedPageState

There will be a separate review for removing this logic from SharedPageState.
More info: https://codereview.chromium.org/1871033002/

BUG=

Committed: https://crrev.com/70390020b54d46b4d34f96429c1db62b1f0629c4
Cr-Commit-Position: refs/heads/master@{#386943}
==========

to

==========
Move profile handling code to a child class of SharedPageState

There will be a separate review for removing this logic from SharedPageState.
More info: https://codereview.chromium.org/1871033002/

BUG=603121

Committed: https://crrev.com/70390020b54d46b4d34f96429c1db62b1f0629c4
Cr-Commit-Position: refs/heads/master@{#386943}
==========

[gurrrik, 2016-04-15 10:16:19]

On 2016/04/13 20:17:41, rnephew1 wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1879193005/ by mailto:rnephew@chromium.org.
> 
> The reason for reverting is: Breaks startup tests.
> crbug.com/603121.

I've uploaded a new patchset with fixes.

Please take a look.

[nednguyen, 2016-04-15 14:17:21]

On 2016/04/15 10:16:19, gurrrik wrote:
> On 2016/04/13 20:17:41, rnephew1 wrote:
> > A revert of this CL (patchset #2 id:20001) has been created in
> > https://codereview.chromium.org/1879193005/ by mailto:rnephew@chromium.org.
> > 
> > The reason for reverting is: Breaks startup tests.
> > crbug.com/603121.
> 
> I've uploaded a new patchset with fixes.
> 
> Please take a look.

lgtm

Would be great if you can add some smoke coverage, or just make sure you run the
benchmark locally before landing the CL

[gurrrik, 2016-04-15 20:08:39]

On 2016/04/15 14:17:21, nednguyen wrote:
> On 2016/04/15 10:16:19, gurrrik wrote:
> > On 2016/04/13 20:17:41, rnephew1 wrote:
> > > A revert of this CL (patchset #2 id:20001) has been created in
> > > https://codereview.chromium.org/1879193005/ by
mailto:rnephew@chromium.org.
> > > 
> > > The reason for reverting is: Breaks startup tests.
> > > crbug.com/603121.
> > 
> > I've uploaded a new patchset with fixes.
> > 
> > Please take a look.
> 
> lgtm
> 
> Would be great if you can add some smoke coverage, or just make sure you run
the
> benchmark locally before landing the CL

I'm not sure how to add it to benchmark_smoke_unittest, so I ran the benchmark
locally, seem like everything is fine now.

[gurrrik, 2016-04-15 20:08:46]

The CQ bit was checked by gurrrik@yandex-team.ru

[gurrrik, 2016-04-15 20:08:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/1884493002/#ps40001
(title: "corrected names of variables")

[commit-bot: I haz the power, 2016-04-15 20:09:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1884493002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1884493002/40001

[commit-bot: I haz the power, 2016-04-15 21:18:51]

Description was changed from

==========
Move profile handling code to a child class of SharedPageState

There will be a separate review for removing this logic from SharedPageState.
More info: https://codereview.chromium.org/1871033002/

BUG=603121

Committed: https://crrev.com/70390020b54d46b4d34f96429c1db62b1f0629c4
Cr-Commit-Position: refs/heads/master@{#386943}
==========

to

==========
Move profile handling code to a child class of SharedPageState

There will be a separate review for removing this logic from SharedPageState.
More info: https://codereview.chromium.org/1871033002/

BUG=603121

Committed: https://crrev.com/70390020b54d46b4d34f96429c1db62b1f0629c4
Cr-Commit-Position: refs/heads/master@{#386943}
==========

[commit-bot: I haz the power, 2016-04-15 21:18:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-15 21:20:12]

Description was changed from

==========
Move profile handling code to a child class of SharedPageState

There will be a separate review for removing this logic from SharedPageState.
More info: https://codereview.chromium.org/1871033002/

BUG=603121

Committed: https://crrev.com/70390020b54d46b4d34f96429c1db62b1f0629c4
Cr-Commit-Position: refs/heads/master@{#386943}
==========

to

==========
Move profile handling code to a child class of SharedPageState

There will be a separate review for removing this logic from SharedPageState.
More info: https://codereview.chromium.org/1871033002/

BUG=603121

Committed: https://crrev.com/70390020b54d46b4d34f96429c1db62b1f0629c4
Cr-Commit-Position: refs/heads/master@{#386943}

Committed: https://crrev.com/7a99b2a7e905842c5ac80617ef666aff8459d541
Cr-Commit-Position: refs/heads/master@{#387697}
==========

[commit-bot: I haz the power, 2016-04-15 21:20:14]

Patchset 3 (id:??) landed as
https://crrev.com/7a99b2a7e905842c5ac80617ef666aff8459d541
Cr-Commit-Position: refs/heads/master@{#387697}