Parsing /proc/cpuinfo for model on Android and Aura

base/cpu.h

Index: base/cpu.h
diff --git a/base/cpu.h b/base/cpu.h
index 595ed97b7ce2c1c2ddb1939d0ce47cd8b51eff65..ffcec7425311b9c585a90abf86da58b809ea38ab 100644
--- a/base/cpu.h
+++ b/base/cpu.h
@@ -58,6 +58,7 @@ class BASE_EXPORT CPU {
   }
   IntelMicroArchitecture GetIntelMicroArchitecture() const;
   const std::string& cpu_brand() const { return cpu_brand_; }
+  static std::string CpuBrandInfo();

[rptr, 2014/03/08 13:03:06]

Used for caching CPU brand string before sandbox is initialized.

[Mark Mentovai, 2014/03/10 14:16:24]

ptr wrote:
A comment like that would belong in the code, not in a code review comment. But…

It seems that this is an implementation detail, and it doesn’t need to be
exposed from this class.

The “sandbox warmup” can simply be creating an instance of a CPU class, since
the constructor does what’s necessary to populate cpu_brand_. You don’t need
this to be exposed separately.

[rptr, 2014/03/11 15:47:14]

Done.

 
  private:
   // Query the processor for CPUID information.