Parsing /proc/cpuinfo for model on Android and Aura

base/cpu.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_CPU_H_
 #define BASE_CPU_H_
 
 #include <string>
 
 #include "base/base_export.h"
@@ skipping 40 matching lines @@
   // operating system support needed to actually call AVX instuctions.
   // Note: you should never need to call this function. It was added in order
   // to workaround a bug in NSS but |has_avx()| is what you want.
   bool has_avx_hardware() const { return has_avx_hardware_; }
   bool has_aesni() const { return has_aesni_; }
   bool has_non_stop_time_stamp_counter() const {
     return has_non_stop_time_stamp_counter_;
   }
   IntelMicroArchitecture GetIntelMicroArchitecture() const;
   const std::string& cpu_brand() const { return cpu_brand_; }
+  static std::string CpuBrandInfo();

[rptr, 2014/03/08 13:03:06]

Used for caching CPU brand string before sandbox is initialized.

[Mark Mentovai, 2014/03/10 14:16:24]

ptr wrote:
A comment like that would belong in the code, not in a code review comment. But…

It seems that this is an implementation detail, and it doesn’t need to be
exposed from this class.

The “sandbox warmup” can simply be creating an instance of a CPU class, since
the constructor does what’s necessary to populate cpu_brand_. You don’t need
this to be exposed separately.

[rptr, 2014/03/11 15:47:14]

Done.

 
  private:
   // Query the processor for CPUID information.
   void Initialize();
 
   int signature_;  // raw form of type, family, model, and stepping
   int type_;  // process type
   int family_;  // family of the processor
   int model_;  // model of processor
   int stepping_;  // processor revision number
@@ skipping 10 matching lines @@
   bool has_avx_hardware_;
   bool has_aesni_;
   bool has_non_stop_time_stamp_counter_;
   std::string cpu_vendor_;
   std::string cpu_brand_;
 };
 
 }  // namespace base
 
 #endif  // BASE_CPU_H_