Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/bindings/main.py

Issue 1884423002: IDL bindings: Avoid extended attributes leaking onto merged interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update license headers and revert layout tests changes (will remove those APIs instead). Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/bindings/main.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/bindings/main.py b/third_party/WebKit/Tools/Scripts/webkitpy/bindings/main.py
index 6841f14e73f5662ad7a66415262d43e711a645a0..4068e8d524c0125849f712f7dbcd3a82aa0dc7f8 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/bindings/main.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/bindings/main.py
@@ -70,6 +70,8 @@ DEPENDENCY_IDL_FILES = frozenset([
'TestPartialInterface2.idl',
'TestPartialInterface3.idl',
'TestPartialInterface4.idl',
bashi 2016/04/19 03:52:51 Not related to your CL, but it seems that we don't
Matt Giuca 2016/04/19 04:30:51 Acknowledged.
Matt Giuca 2016/04/19 05:08:18 Done.
+ 'TestInterface2Partial.idl',
bashi 2016/04/19 03:52:51 Could you follow the convention? TestPartialInterf
Matt Giuca 2016/04/19 04:30:51 I thought about that but it seemed funny to have T
bashi 2016/04/19 04:50:27 Makes sense. Probably we should rename "TestPartia
Matt Giuca 2016/04/19 05:08:18 Acknowledged.
+ 'TestInterface2Partial2.idl',
bashi 2016/04/19 03:52:51 TestPartialInterface5.idl
])
# core/inspector/InspectorInstrumentation.idl is not a valid Blink IDL.
« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698