Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/bindings/main.py

Issue 1884423002: IDL bindings: Avoid extended attributes leaking onto merged interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update license headers and revert layout tests changes (will remove those APIs instead). Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2011 Google Inc. All rights reserved. 1 # Copyright (C) 2011 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions 4 # modification, are permitted provided that the following conditions
5 # are met: 5 # are met:
6 # 1. Redistributions of source code must retain the above copyright 6 # 1. Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # 2. Redistributions in binary form must reproduce the above copyright 8 # 2. Redistributions in binary form must reproduce the above copyright
9 # notice, this list of conditions and the following disclaimer in the 9 # notice, this list of conditions and the following disclaimer in the
10 # documentation and/or other materials provided with the distribution. 10 # documentation and/or other materials provided with the distribution.
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 TBR=(someone in Source/bindings/OWNERS or WATCHLISTS:bindings) 62 TBR=(someone in Source/bindings/OWNERS or WATCHLISTS:bindings)
63 """ 63 """
64 64
65 DEPENDENCY_IDL_FILES = frozenset([ 65 DEPENDENCY_IDL_FILES = frozenset([
66 'TestImplements.idl', 66 'TestImplements.idl',
67 'TestImplements2.idl', 67 'TestImplements2.idl',
68 'TestImplements3.idl', 68 'TestImplements3.idl',
69 'TestPartialInterface.idl', 69 'TestPartialInterface.idl',
70 'TestPartialInterface2.idl', 70 'TestPartialInterface2.idl',
71 'TestPartialInterface3.idl', 71 'TestPartialInterface3.idl',
72 'TestPartialInterface4.idl', 72 'TestPartialInterface4.idl',
bashi 2016/04/19 03:52:51 Not related to your CL, but it seems that we don't
Matt Giuca 2016/04/19 04:30:51 Acknowledged.
Matt Giuca 2016/04/19 05:08:18 Done.
73 'TestInterface2Partial.idl',
bashi 2016/04/19 03:52:51 Could you follow the convention? TestPartialInterf
Matt Giuca 2016/04/19 04:30:51 I thought about that but it seemed funny to have T
bashi 2016/04/19 04:50:27 Makes sense. Probably we should rename "TestPartia
Matt Giuca 2016/04/19 05:08:18 Acknowledged.
74 'TestInterface2Partial2.idl',
bashi 2016/04/19 03:52:51 TestPartialInterface5.idl
73 ]) 75 ])
74 76
75 # core/inspector/InspectorInstrumentation.idl is not a valid Blink IDL. 77 # core/inspector/InspectorInstrumentation.idl is not a valid Blink IDL.
76 NON_BLINK_IDL_FILES = frozenset([ 78 NON_BLINK_IDL_FILES = frozenset([
77 'InspectorInstrumentation.idl', 79 'InspectorInstrumentation.idl',
78 ]) 80 ])
79 81
80 COMPONENT_DIRECTORY = frozenset(['core', 'modules']) 82 COMPONENT_DIRECTORY = frozenset(['core', 'modules'])
81 83
82 test_input_directory = os.path.join(source_path, 'bindings', 'tests', 'idls') 84 test_input_directory = os.path.join(source_path, 'bindings', 'tests', 'idls')
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
345 347
346 348
347 def run_bindings_tests(reset_results, verbose): 349 def run_bindings_tests(reset_results, verbose):
348 # Generate output into the reference directory if resetting results, or 350 # Generate output into the reference directory if resetting results, or
349 # a temp directory if not. 351 # a temp directory if not.
350 if reset_results: 352 if reset_results:
351 print 'Resetting results' 353 print 'Resetting results'
352 return bindings_tests(reference_directory, verbose) 354 return bindings_tests(reference_directory, verbose)
353 with TemporaryDirectory() as temp_dir: 355 with TemporaryDirectory() as temp_dir:
354 return bindings_tests(temp_dir, verbose) 356 return bindings_tests(temp_dir, verbose)
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698