Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1884403002: [X87] [TurboFan] Fix kX87Float64ToUint32 code generation bug. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[X87] [TurboFan] Fix kX87Float64ToUint32 code generation bug. The CL #35176 (https://codereview.chromium.org/1843983002) exposed one hidden bug in x87 turbofan code generation for kX87Float64ToUint32. The current kX87Float64ToUint32 code generation will destroy the input value in X87 FPU stack which will be used by the following code. This CL fixed this bug. BUG= Committed: https://crrev.com/fd936fac3f0e382830f550a81216b8723dde7bd5 Cr-Commit-Position: refs/heads/master@{#35507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-15 04:04:17 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-04-15 06:08:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884403002/1
4 years, 8 months ago (2016-04-15 06:18:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 06:36:00 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 06:36:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd936fac3f0e382830f550a81216b8723dde7bd5
Cr-Commit-Position: refs/heads/master@{#35507}

Powered by Google App Engine
This is Rietveld 408576698