Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 1843983002: [wasm] Fixed float-to-int conversion tests. (Closed)

Created:
4 years, 8 months ago by ahaas
Modified:
4 years, 8 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fixed float-to-int conversion tests. *) For all tests the input validation was incorrect, i.e. some values were considered invalid although they were valid. The problem was that values which are outside int range can get in range through truncation. *) Removed an assertion in the x64 code generation of TruncateFloat64ToUint32 which trapped on negative inputs. *) Introduced a new TF operator TruncateFloat32ToUint32 which does the same as ChangeFloat32ToUint32 but does not trap on negative inputs. R=titzer@chromium.org Committed: https://crrev.com/ac7f0e2b6183839e55136647f81d6c01ac1b93af Cr-Commit-Position: refs/heads/master@{#35176}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -13 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 1 chunk +7 lines, -1 line 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 4 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ahaas
4 years, 8 months ago (2016-03-30 16:15:44 UTC) #1
titzer
lgtm https://codereview.chromium.org/1843983002/diff/1/src/compiler/x64/instruction-selector-x64.cc File src/compiler/x64/instruction-selector-x64.cc (right): https://codereview.chromium.org/1843983002/diff/1/src/compiler/x64/instruction-selector-x64.cc#newcode898 src/compiler/x64/instruction-selector-x64.cc:898: Emit(kSSEFloat64ToUint32 | MiscField::encode(true), g.DefineAsRegister(node), Pass 1 here instead ...
4 years, 8 months ago (2016-03-31 09:02:55 UTC) #2
ahaas
On 2016/03/31 at 09:02:55, titzer wrote: > lgtm > > https://codereview.chromium.org/1843983002/diff/1/src/compiler/x64/instruction-selector-x64.cc > File src/compiler/x64/instruction-selector-x64.cc (right): ...
4 years, 8 months ago (2016-03-31 17:34:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843983002/20001
4 years, 8 months ago (2016-03-31 17:35:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-31 18:38:21 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 18:38:43 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ac7f0e2b6183839e55136647f81d6c01ac1b93af
Cr-Commit-Position: refs/heads/master@{#35176}

Powered by Google App Engine
This is Rietveld 408576698