[remoting android] Plumb It2Me events from C++ to Java

[remoting android] Plumb It2Me events from C++ to Java

This allows the Java app to handle state-changes and receive the IT2Me
access-code.

BUG=602355
Committed: https://crrev.com/0830300bb65e48439b3ac3fd2b1c99d42c44df94
Cr-Commit-Position: refs/heads/master@{#390217}

[Lambros, 2016-04-15 02:07:01]

lambroslambrou@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Sergey Ulanov, 2016-04-15 19:42:05]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-04-15 19:42:06]

lgtm

https://codereview.chromium.org/1884253003/diff/1/remoting/android/host/src/o...
File remoting/android/host/src/org/chromium/chromoting/host/jni/Host.java
(right):

https://codereview.chromium.org/1884253003/diff/1/remoting/android/host/src/o...
remoting/android/host/src/org/chromium/chromoting/host/jni/Host.java:46:
nativeDestroy(mNativeJniHost);
set mNativeJniHost to 0 here in case destroy() is called twice.

https://codereview.chromium.org/1884253003/diff/1/remoting/android/host/src/o...
File
remoting/android/host/src/org/chromium/chromoting/host/jni/It2MeObserver.java
(right):

https://codereview.chromium.org/1884253003/diff/1/remoting/android/host/src/o...
remoting/android/host/src/org/chromium/chromoting/host/jni/It2MeObserver.java:8:
public interface It2MeObserver {
Call it It2MeHostObserver.

https://codereview.chromium.org/1884253003/diff/1/remoting/android/host/src/o...
remoting/android/host/src/org/chromium/chromoting/host/jni/It2MeObserver.java:25:
void onStoreAccessCode(String accessCode, int lifetimeSeconds);
I don't think this is a good name for this method. The access code is not
supposed to be stored anywhere. it should be onAccessCode() or
onAccessCodeReceived(). I realize that this name reflects what we have in the
C++ version of this interface, but still think it's better to call it
differently here and maybe rename in C++ code later.

https://codereview.chromium.org/1884253003/diff/1/remoting/host/android/jni_h...
File remoting/host/android/jni_host.cc (right):

https://codereview.chromium.org/1884253003/diff/1/remoting/host/android/jni_h...
remoting/host/android/jni_host.cc:105: ConvertUTF8ToJavaString(env,
access_code).obj(),
incorrect indentation. clang-format please

[Sergey Ulanov, 2016-04-15 19:42:11]

The CQ bit was unchecked by sergeyu@chromium.org

[Lambros, 2016-04-22 22:31:59]

https://codereview.chromium.org/1884253003/diff/1/remoting/android/host/src/o...
File remoting/android/host/src/org/chromium/chromoting/host/jni/Host.java
(right):

https://codereview.chromium.org/1884253003/diff/1/remoting/android/host/src/o...
remoting/android/host/src/org/chromium/chromoting/host/jni/Host.java:46:
nativeDestroy(mNativeJniHost);
On 2016/04/15 19:42:05, Sergey Ulanov wrote:
> set mNativeJniHost to 0 here in case destroy() is called twice.

Done.

https://codereview.chromium.org/1884253003/diff/1/remoting/android/host/src/o...
File
remoting/android/host/src/org/chromium/chromoting/host/jni/It2MeObserver.java
(right):

https://codereview.chromium.org/1884253003/diff/1/remoting/android/host/src/o...
remoting/android/host/src/org/chromium/chromoting/host/jni/It2MeObserver.java:8:
public interface It2MeObserver {
On 2016/04/15 19:42:05, Sergey Ulanov wrote:
> Call it It2MeHostObserver.

Done.

https://codereview.chromium.org/1884253003/diff/1/remoting/android/host/src/o...
remoting/android/host/src/org/chromium/chromoting/host/jni/It2MeObserver.java:25:
void onStoreAccessCode(String accessCode, int lifetimeSeconds);
On 2016/04/15 19:42:05, Sergey Ulanov wrote:
> I don't think this is a good name for this method. The access code is not
> supposed to be stored anywhere. it should be onAccessCode() or
> onAccessCodeReceived(). I realize that this name reflects what we have in the
> C++ version of this interface, but still think it's better to call it
> differently here and maybe rename in C++ code later. 

Done.

https://codereview.chromium.org/1884253003/diff/1/remoting/host/android/jni_h...
File remoting/host/android/jni_host.cc (right):

https://codereview.chromium.org/1884253003/diff/1/remoting/host/android/jni_h...
remoting/host/android/jni_host.cc:105: ConvertUTF8ToJavaString(env,
access_code).obj(),
On 2016/04/15 19:42:06, Sergey Ulanov wrote:
> incorrect indentation. clang-format please

Done.

[Lambros, 2016-04-26 17:03:41]

The CQ bit was checked by lambroslambrou@chromium.org

[Lambros, 2016-04-26 17:03:42]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/1884253003/#ps40001
(title: "Address comments, git cl format")

[commit-bot: I haz the power, 2016-04-26 17:04:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1884253003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1884253003/40001

[commit-bot: I haz the power, 2016-04-26 17:06:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 17:06:33]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Lambros, 2016-04-26 20:35:44]

Patchset #4 (id:60001) has been deleted

[Lambros, 2016-04-27 21:30:50]

The CQ bit was checked by lambroslambrou@chromium.org

[Lambros, 2016-04-27 21:30:51]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/1884253003/#ps40001
(title: "Address comments, git cl format")

[commit-bot: I haz the power, 2016-04-27 21:31:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1884253003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1884253003/40001

[commit-bot: I haz the power, 2016-04-27 22:26:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:14:00]

Patchset 3 (id:??) landed as
https://crrev.com/0830300bb65e48439b3ac3fd2b1c99d42c44df94
Cr-Commit-Position: refs/heads/master@{#390217}

[commit-bot: I haz the power, 2016-04-30 17:52:30]

Description was changed from

==========
[remoting android] Plumb It2Me events from C++ to Java

This allows the Java app to handle state-changes and receive the IT2Me
access-code.

BUG=602355
==========

to

==========
[remoting android] Plumb It2Me events from C++ to Java

This allows the Java app to handle state-changes and receive the IT2Me
access-code.

BUG=602355

Committed: https://crrev.com/0830300bb65e48439b3ac3fd2b1c99d42c44df94
Cr-Commit-Position: refs/heads/master@{#390217}
==========