[remoting android] Initialize It2Me host and implement Connect()

Reland: [remoting android] Initialize It2Me host and implement Connect()

Add dependency on google_play_resources.

Original description:
This adds a "Share" button. Clicking it brings up an account-chooser
dialog for selecting the account to use for XMPP.
Then it connects to the Directory server, and gets back an It2Me access
code.

BUG=602355
Committed: https://crrev.com/709327e18fc43a9a0f492f15936c2e157f7b9add
Cr-Commit-Position: refs/heads/master@{#389835}

[Lambros, 2016-04-14 01:29:01]

lambroslambrou@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Lambros, 2016-04-14 01:29:01]

This is a bit quick-and-dirty. I copied the OAuthTokenFetcher class from the
client and tweaked it a bit. We should maybe create a remoting/android/base/
directory for Java code common to both client and host?
Also, we will want to re-use the AccountSwitcher for a nicer UI.

[Sergey Ulanov, 2016-04-19 00:03:06]

Do we need android/host directory? You made separate namespace anyway. Why not
just put all host code in
remoting/android/java/src/org/chromium/chromoting/host?

[Lambros, 2016-04-19 16:50:10]

On 2016/04/19 00:03:06, Sergey Ulanov wrote:
> Do we need android/host directory? You made separate namespace anyway. Why not
> just put all host code in
> remoting/android/java/src/org/chromium/chromoting/host?

We could do it this way (though I would still want to define
org/chromium/chromoting/base/
for utilities that can be used by both client and host code).

However, looking at https://www.chromium.org/developers/coding-style/java
it seems that it would be better to do this, following Chromium style:

Put common Java code in
remoting/base/android/java/src/org/chromium/chromoting/

Put any client-specific code in
remoting/client/android/java/src/org/chromium/chromoting/client/
(anything not required by the host-only build)

Put host code in
remoting/host/android/java/src/org/chromium/chromoting/host/

Keep the main application code in remoting/android/java/...
and allow it to depend on base, client and host, in order to build an APK
that includes client and host functionality.

And have the host-only build depend on only base and host.
The dependencies can be enforced by checkdeps.

[Sergey Ulanov, 2016-04-20 00:03:19]

On 2016/04/19 16:50:10, Lambros wrote:
> On 2016/04/19 00:03:06, Sergey Ulanov wrote:
> > Do we need android/host directory? You made separate namespace anyway. Why
not
> > just put all host code in
> > remoting/android/java/src/org/chromium/chromoting/host?
> 
> We could do it this way (though I would still want to define
> org/chromium/chromoting/base/
> for utilities that can be used by both client and host code).
> 
> However, looking at https://www.chromium.org/developers/coding-style/java
> it seems that it would be better to do this, following Chromium style:

If I understand correctly that guide applies only to top-level directories. I
think that separating remoting java code in src/remoting subdirectories would
make it only harder to work with it and there are no benefits we would get from
it.

> 
> Put common Java code in
> remoting/base/android/java/src/org/chromium/chromoting/
> 
> Put any client-specific code in
> remoting/client/android/java/src/org/chromium/chromoting/client/
> (anything not required by the host-only build)
> 
> Put host code in
> remoting/host/android/java/src/org/chromium/chromoting/host/
> 
> Keep the main application code in remoting/android/java/...
> and allow it to depend on base, client and host, in order to build an APK
> that includes client and host functionality.
> 
> And have the host-only build depend on only base and host.
> The dependencies can be enforced by checkdeps.

[Lambros, 2016-04-20 17:19:50]

On 2016/04/20 00:03:19, Sergey Ulanov wrote:
> On 2016/04/19 16:50:10, Lambros wrote:
> > On 2016/04/19 00:03:06, Sergey Ulanov wrote:
> > > Do we need android/host directory? You made separate namespace anyway. Why
> not
> > > just put all host code in
> > > remoting/android/java/src/org/chromium/chromoting/host?

Doing this breaks the GYP build:

android/java/src/org/chromium/chromoting/host/MainActivity.java:20: error:
package R does not exist
        setContentView(R.layout.main);
                        ^
android/java/src/org/chromium/chromoting/host/MainActivity.java:22: error:
package R does not exist
        Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar);

The problem is with the generated resource classes.
The host Java code uses org.chromium.chromoting.host.R
but the client code uses org.chromium.chromoting.R.
There's no obvious way to tell the GYP build to generate
both of these R classes for the
remoting_android_client_java target.

I could have the host resources go in '.R' instead of
'.host.R', but that would risks collisions when
mixing client and host resource IDs.

For now, I propose to keep the directories the way they are
currently, and to simply list base/OAuthTokenFetcher.java in
the host sources list.

[Sergey Ulanov, 2016-04-20 17:24:54]

On 2016/04/20 17:19:50, Lambros wrote:
> On 2016/04/20 00:03:19, Sergey Ulanov wrote:
> > On 2016/04/19 16:50:10, Lambros wrote:
> > > On 2016/04/19 00:03:06, Sergey Ulanov wrote:
> > > > Do we need android/host directory? You made separate namespace anyway.
Why
> > not
> > > > just put all host code in
> > > > remoting/android/java/src/org/chromium/chromoting/host?
> 
> Doing this breaks the GYP build:
> 
> android/java/src/org/chromium/chromoting/host/MainActivity.java:20: error:
> package R does not exist
>         setContentView(R.layout.main);
>                         ^
> android/java/src/org/chromium/chromoting/host/MainActivity.java:22: error:
> package R does not exist
>         Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar);
> 
> The problem is with the generated resource classes.
> The host Java code uses org.chromium.chromoting.host.R
> but the client code uses org.chromium.chromoting.R.
> There's no obvious way to tell the GYP build to generate
> both of these R classes for the
> remoting_android_client_java target.
> 
> I could have the host resources go in '.R' instead of
> '.host.R', but that would risks collisions when
> mixing client and host resource IDs.
> 
> For now, I propose to keep the directories the way they are
> currently, and to simply list base/OAuthTokenFetcher.java in
> the host sources list.

sgtm

[Lambros, 2016-04-20 23:52:16]

ptal

[Sergey Ulanov, 2016-04-21 18:01:41]

lgtm

[Lambros, 2016-04-21 20:03:50]

The CQ bit was checked by lambroslambrou@chromium.org

[commit-bot: I haz the power, 2016-04-21 20:04:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1888653002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1888653002/40001

[commit-bot: I haz the power, 2016-04-21 20:47:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 20:47:53]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[Lambros, 2016-04-22 00:36:41]

The CQ bit was checked by lambroslambrou@chromium.org

[Lambros, 2016-04-22 00:36:42]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/1888653002/#ps60001
(title: "Remove native_messaging from Android unittests")

[commit-bot: I haz the power, 2016-04-22 00:37:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1888653002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1888653002/60001

[commit-bot: I haz the power, 2016-04-22 01:57:57]

Committed patchset #4 (id:60001)

[jbudorick, 2016-04-22 02:43:41]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1913023002/ by jbudorick@chromium.org.

The reason for reverting is: breaks downstream compilation.

[Lambros, 2016-04-22 19:11:14]

Description was changed from

==========
[remoting android] Initialize It2Me host and implement Connect()

This adds a "Share" button. Clicking it brings up an account-chooser
dialog for selecting the account to use for XMPP.
Then it connects to the Directory server, and gets back an It2Me access
code.

BUG=602355
==========

to

==========
Reland: [remoting android] Initialize It2Me host and implement Connect()

Added google_play_resources dependency.
Original description:

This adds a "Share" button. Clicking it brings up an account-chooser
dialog for selecting the account to use for XMPP.
Then it connects to the Directory server, and gets back an It2Me access
code.

BUG=602355
==========

[Lambros, 2016-04-22 19:11:43]

The CQ bit was checked by lambroslambrou@chromium.org

[Lambros, 2016-04-22 19:11:43]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/1888653002/#ps80001
(title: "Add missing resource dependency")

[commit-bot: I haz the power, 2016-04-22 19:12:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1888653002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1888653002/80001

[commit-bot: I haz the power, 2016-04-22 19:43:21]

Description was changed from

==========
Reland: [remoting android] Initialize It2Me host and implement Connect()

Added google_play_resources dependency.
Original description:

This adds a "Share" button. Clicking it brings up an account-chooser
dialog for selecting the account to use for XMPP.
Then it connects to the Directory server, and gets back an It2Me access
code.

BUG=602355
==========

to

==========
[remoting android] Initialize It2Me host and implement Connect()

This adds a "Share" button. Clicking it brings up an account-chooser
dialog for selecting the account to use for XMPP.
Then it connects to the Directory server, and gets back an It2Me access
code.

BUG=602355

Committed: https://crrev.com/2b5df9eece16617116bc4fdbcf79198288ad2844
Cr-Commit-Position: refs/heads/master@{#388999}
==========

[commit-bot: I haz the power, 2016-04-22 19:43:22]

Patchset 5 (id:??) landed as
https://crrev.com/2b5df9eece16617116bc4fdbcf79198288ad2844
Cr-Commit-Position: refs/heads/master@{#388999}

[Lambros, 2016-04-26 18:11:43]

Description was changed from

==========
[remoting android] Initialize It2Me host and implement Connect()

This adds a "Share" button. Clicking it brings up an account-chooser
dialog for selecting the account to use for XMPP.
Then it connects to the Directory server, and gets back an It2Me access
code.

BUG=602355

Committed: https://crrev.com/2b5df9eece16617116bc4fdbcf79198288ad2844
Cr-Commit-Position: refs/heads/master@{#388999}
==========

to

==========
Reland: [remoting android] Initialize It2Me host and implement Connect()

Add dependency on google_play_resources.

Original description:
This adds a "Share" button. Clicking it brings up an account-chooser
dialog for selecting the account to use for XMPP.
Then it connects to the Directory server, and gets back an It2Me access
code.

BUG=602355
==========

[Lambros, 2016-04-26 18:14:46]

The CQ bit was checked by lambroslambrou@chromium.org

[Lambros, 2016-04-26 18:14:46]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/1888653002/#ps100001
(title: "Rebase/re-upload since Reitveld is confused")

[commit-bot: I haz the power, 2016-04-26 18:15:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1888653002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1888653002/100001

[commit-bot: I haz the power, 2016-04-26 19:07:51]

Description was changed from

==========
Reland: [remoting android] Initialize It2Me host and implement Connect()

Add dependency on google_play_resources.

Original description:
This adds a "Share" button. Clicking it brings up an account-chooser
dialog for selecting the account to use for XMPP.
Then it connects to the Directory server, and gets back an It2Me access
code.

BUG=602355
==========

to

==========
Reland: [remoting android] Initialize It2Me host and implement Connect()

Add dependency on google_play_resources.

Original description:
This adds a "Share" button. Clicking it brings up an account-chooser
dialog for selecting the account to use for XMPP.
Then it connects to the Directory server, and gets back an It2Me access
code.

BUG=602355
==========

[commit-bot: I haz the power, 2016-04-26 19:07:52]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-26 19:09:10]

Description was changed from

==========
Reland: [remoting android] Initialize It2Me host and implement Connect()

Add dependency on google_play_resources.

Original description:
This adds a "Share" button. Clicking it brings up an account-chooser
dialog for selecting the account to use for XMPP.
Then it connects to the Directory server, and gets back an It2Me access
code.

BUG=602355
==========

to

==========
Reland: [remoting android] Initialize It2Me host and implement Connect()

Add dependency on google_play_resources.

Original description:
This adds a "Share" button. Clicking it brings up an account-chooser
dialog for selecting the account to use for XMPP.
Then it connects to the Directory server, and gets back an It2Me access
code.

BUG=602355

Committed: https://crrev.com/709327e18fc43a9a0f492f15936c2e157f7b9add
Cr-Commit-Position: refs/heads/master@{#389835}
==========

[commit-bot: I haz the power, 2016-04-26 19:09:11]

Patchset 6 (id:??) landed as
https://crrev.com/709327e18fc43a9a0f492f15936c2e157f7b9add
Cr-Commit-Position: refs/heads/master@{#389835}