Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_request.h

Issue 1884073002: Add a new metric for how many times permissions prompts are shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix browser tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/permission_bubble_request.h
diff --git a/chrome/browser/ui/website_settings/permission_bubble_request.h b/chrome/browser/ui/website_settings/permission_bubble_request.h
index 9da18802c0140d08db1ec94f16a90e49603ec84c..412aea8b565454a9520ffa74cd08bfb570aa0760 100644
--- a/chrome/browser/ui/website_settings/permission_bubble_request.h
+++ b/chrome/browser/ui/website_settings/permission_bubble_request.h
@@ -12,6 +12,18 @@ namespace gfx {
enum class VectorIconId;
}
+// Used for UMA to record the types of permission prompts shown.
tsergeant 2016/04/15 00:54:10 Maybe add a note that this corresponds to the Perm
benwells 2016/04/18 01:02:06 Done.
+enum class PermissionBubbleType {
+ UNKNOWN,
+ MULTIPLE,
+ PERMISSION,
+ QUOTA,
+ DOWNLOAD,
+ MEDIA_STREAM,
+ REGISTER_PROTOCOL_HANDLER,
+ NUM
+};
+
// Describes the interface a feature utilizing permission bubbles should
// implement. A class of this type is registered with the permission bubble
// manager to receive updates about the result of the permissions request
@@ -62,6 +74,8 @@ class PermissionBubbleRequest {
// no further message from the permission bubble system. This method will
// eventually be called on every request which is not unregistered.
virtual void RequestFinished() = 0;
+
+ virtual PermissionBubbleType GetPermissionBubbleType() const;
};
#endif // CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_REQUEST_H_

Powered by Google App Engine
This is Rietveld 408576698