Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Unified Diff: chrome/browser/chrome_quota_permission_context.cc

Issue 1884073002: Add a new metric for how many times permissions prompts are shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix browser tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_quota_permission_context.cc
diff --git a/chrome/browser/chrome_quota_permission_context.cc b/chrome/browser/chrome_quota_permission_context.cc
index 0de3b2b12d3ae3130d61b60f306ef406eac5f339..6959d46d92701edcc4dd34c217180b3c7f2b1bc4 100644
--- a/chrome/browser/chrome_quota_permission_context.cc
+++ b/chrome/browser/chrome_quota_permission_context.cc
@@ -52,6 +52,7 @@ class QuotaPermissionRequest : public PermissionBubbleRequest {
~QuotaPermissionRequest() override;
+ private:
tsergeant 2016/04/15 00:54:10 Why does everything go from public to private here
benwells 2016/04/18 01:02:06 As discussed offline, this means users of these me
// PermissionBubbleRequest:
int GetIconId() const override;
base::string16 GetMessageText() const override;
@@ -61,8 +62,8 @@ class QuotaPermissionRequest : public PermissionBubbleRequest {
void PermissionDenied() override;
void Cancelled() override;
void RequestFinished() override;
+ PermissionBubbleType GetPermissionBubbleType() const override;
- private:
scoped_refptr<ChromeQuotaPermissionContext> context_;
GURL origin_url_;
int64_t requested_quota_;
@@ -131,6 +132,10 @@ void QuotaPermissionRequest::RequestFinished() {
delete this;
}
+PermissionBubbleType QuotaPermissionRequest::GetPermissionBubbleType() const {
+ return PermissionBubbleType::QUOTA;
+}
+
#if defined(OS_ANDROID)
// RequestQuotaInfoBarDelegate ------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698