Add a new metric for how many times permissions prompts are shown.

chrome/browser/chrome_quota_permission_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_quota_permission_context.h"
 
 #include <stdint.h>
 
 #include <string>
 
@@ skipping 34 matching lines @@
 class QuotaPermissionRequest : public PermissionBubbleRequest {
  public:
   QuotaPermissionRequest(
       ChromeQuotaPermissionContext* context,
       const GURL& origin_url,
       int64_t requested_quota,
       const content::QuotaPermissionContext::PermissionCallback& callback);
 
   ~QuotaPermissionRequest() override;
 
+ private:

[tsergeant, 2016/04/15 00:54:10]

Why does everything go from public to private here (and in several of the other
classes you're changing)?

[benwells, 2016/04/18 01:02:06]

As discussed offline, this means users of these methods have to know of
instances of this class as a PermissionBubbleRequest, not a
QuotaPermissionRequest, which is more abstract and in general better as it means
it is being treated generally.

This is something I've been asked many times and seems to be a convention in
chromium. Note that if you google around some people think it is a bad idea.

   // PermissionBubbleRequest:
   int GetIconId() const override;
   base::string16 GetMessageText() const override;
   base::string16 GetMessageTextFragment() const override;
   GURL GetOrigin() const override;
   void PermissionGranted() override;
   void PermissionDenied() override;
   void Cancelled() override;
   void RequestFinished() override;
+  PermissionBubbleType GetPermissionBubbleType() const override;
 
- private:
   scoped_refptr<ChromeQuotaPermissionContext> context_;
   GURL origin_url_;
   int64_t requested_quota_;
   content::QuotaPermissionContext::PermissionCallback callback_;
 
   DISALLOW_COPY_AND_ASSIGN(QuotaPermissionRequest);
 };
 
 QuotaPermissionRequest::QuotaPermissionRequest(
     ChromeQuotaPermissionContext* context,
@@ skipping 48 matching lines @@
 void QuotaPermissionRequest::RequestFinished() {
   if (!callback_.is_null()) {
     context_->DispatchCallbackOnIOThread(
         callback_,
         content::QuotaPermissionContext::QUOTA_PERMISSION_RESPONSE_CANCELLED);
   }
 
   delete this;
 }
 
+PermissionBubbleType QuotaPermissionRequest::GetPermissionBubbleType() const {
+  return PermissionBubbleType::QUOTA;
+}
+
 #if defined(OS_ANDROID)
 // RequestQuotaInfoBarDelegate ------------------------------------------------
 
 class RequestQuotaInfoBarDelegate : public ConfirmInfoBarDelegate {
  public:
   // Creates a request quota infobar and delegate and adds the infobar to
   // |infobar_service|.
   static void Create(
       InfoBarService* infobar_service,
       ChromeQuotaPermissionContext* context,
@@ skipping 157 matching lines @@
         content::BrowserThread::IO, FROM_HERE,
         base::Bind(&ChromeQuotaPermissionContext::DispatchCallbackOnIOThread,
                    this, callback, response));
     return;
   }
 
   callback.Run(response);
 }
 
 ChromeQuotaPermissionContext::~ChromeQuotaPermissionContext() {}