chrome/browser/permissions/permission_bubble_request_impl.h - Issue 1884073002: Add a new metric for how many times permissions prompts are shown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_bubble_request_impl.h

Issue 1884073002: Add a new metric for how many times permissions prompts are shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/media_stream_devices_controller.cc ('k') | chrome/browser/permissions/permission_bubble_request_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_bubble_request_impl.h

diff --git a/chrome/browser/permissions/permission_bubble_request_impl.h b/chrome/browser/permissions/permission_bubble_request_impl.h

index 5e1a470e111bdd9a2b9fe3b57ba56e6def4983e9..75e2bf304ca9610a2c687ab111229e41ad1ff3e4 100644

--- a/chrome/browser/permissions/permission_bubble_request_impl.h

+++ b/chrome/browser/permissions/permission_bubble_request_impl.h

@@ -30,6 +30,10 @@ class PermissionBubbleRequestImpl : public PermissionBubbleRequest {

~PermissionBubbleRequestImpl() override;

+ protected:

+ void RegisterActionTaken() { action_taken_ = true; }

+ private:

// PermissionBubbleRequest:

gfx::VectorIconId GetVectorIconId() const override;

int GetIconId() const override;

@@ -42,11 +46,8 @@ class PermissionBubbleRequestImpl : public PermissionBubbleRequest {

void PermissionDenied() override;

void Cancelled() override;

void RequestFinished() override;

+ PermissionBubbleType GetPermissionBubbleType() const override;

- protected:

- void RegisterActionTaken() { action_taken_ = true; }

- private:

GURL request_origin_;

content::PermissionType permission_type_;