Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: chrome/browser/permissions/permission_bubble_request_impl.h

Issue 1884073002: Add a new metric for how many times permissions prompts are shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_BUBBLE_REQUEST_IMPL_H_ 5 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_BUBBLE_REQUEST_IMPL_H_
6 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_BUBBLE_REQUEST_IMPL_H_ 6 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_BUBBLE_REQUEST_IMPL_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "chrome/browser/permissions/permission_request_id.h" 10 #include "chrome/browser/permissions/permission_request_id.h"
(...skipping 12 matching lines...) Expand all
23 using PermissionDecidedCallback = base::Callback<void(bool, ContentSetting)>; 23 using PermissionDecidedCallback = base::Callback<void(bool, ContentSetting)>;
24 24
25 PermissionBubbleRequestImpl( 25 PermissionBubbleRequestImpl(
26 const GURL& request_origin, 26 const GURL& request_origin,
27 content::PermissionType permission_type, 27 content::PermissionType permission_type,
28 const PermissionDecidedCallback& permission_decided_callback, 28 const PermissionDecidedCallback& permission_decided_callback,
29 const base::Closure delete_callback); 29 const base::Closure delete_callback);
30 30
31 ~PermissionBubbleRequestImpl() override; 31 ~PermissionBubbleRequestImpl() override;
32 32
33 protected:
34 void RegisterActionTaken() { action_taken_ = true; }
35
36 private:
33 // PermissionBubbleRequest: 37 // PermissionBubbleRequest:
34 gfx::VectorIconId GetVectorIconId() const override; 38 gfx::VectorIconId GetVectorIconId() const override;
35 int GetIconId() const override; 39 int GetIconId() const override;
36 base::string16 GetMessageText() const override; 40 base::string16 GetMessageText() const override;
37 base::string16 GetMessageTextFragment() const override; 41 base::string16 GetMessageTextFragment() const override;
38 GURL GetOrigin() const override; 42 GURL GetOrigin() const override;
39 // Remember to call RegisterActionTaken for these methods if you are 43 // Remember to call RegisterActionTaken for these methods if you are
40 // overriding them. 44 // overriding them.
41 void PermissionGranted() override; 45 void PermissionGranted() override;
42 void PermissionDenied() override; 46 void PermissionDenied() override;
43 void Cancelled() override; 47 void Cancelled() override;
44 void RequestFinished() override; 48 void RequestFinished() override;
49 PermissionBubbleType GetPermissionBubbleType() const override;
45 50
46 protected:
47 void RegisterActionTaken() { action_taken_ = true; }
48
49 private:
50 GURL request_origin_; 51 GURL request_origin_;
51 content::PermissionType permission_type_; 52 content::PermissionType permission_type_;
52 53
53 // Called once a decision is made about the permission. 54 // Called once a decision is made about the permission.
54 const PermissionDecidedCallback permission_decided_callback_; 55 const PermissionDecidedCallback permission_decided_callback_;
55 56
56 // Called when the bubble is no longer in use so it can be deleted by 57 // Called when the bubble is no longer in use so it can be deleted by
57 // the caller. 58 // the caller.
58 const base::Closure delete_callback_; 59 const base::Closure delete_callback_;
59 bool is_finished_; 60 bool is_finished_;
60 bool action_taken_; 61 bool action_taken_;
61 62
62 DISALLOW_COPY_AND_ASSIGN(PermissionBubbleRequestImpl); 63 DISALLOW_COPY_AND_ASSIGN(PermissionBubbleRequestImpl);
63 }; 64 };
64 65
65 #endif // CHROME_BROWSER_PERMISSIONS_PERMISSION_BUBBLE_REQUEST_IMPL_H_ 66 #endif // CHROME_BROWSER_PERMISSIONS_PERMISSION_BUBBLE_REQUEST_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/browser/media/media_stream_devices_controller.cc ('k') | chrome/browser/permissions/permission_bubble_request_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698