chrome/browser/custom_handlers/register_protocol_handler_permission_request.h - Issue 1884073002: Add a new metric for how many times permissions prompts are shown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/custom_handlers/register_protocol_handler_permission_request.h

Issue 1884073002: Add a new metric for how many times permissions prompts are shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_quota_permission_context.cc ('k') | chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/custom_handlers/register_protocol_handler_permission_request.h

diff --git a/chrome/browser/custom_handlers/register_protocol_handler_permission_request.h b/chrome/browser/custom_handlers/register_protocol_handler_permission_request.h

index db0e1435d0a1d6558b88f056a972d1e03ac9d78d..5e50d50ff3f1358d9e21702b5bb7ab223a0f32a5 100644

--- a/chrome/browser/custom_handlers/register_protocol_handler_permission_request.h

+++ b/chrome/browser/custom_handlers/register_protocol_handler_permission_request.h

@@ -24,6 +24,7 @@ class RegisterProtocolHandlerPermissionRequest

bool user_gesture);

~RegisterProtocolHandlerPermissionRequest() override;

+ private:

// PermissionBubbleRequest:

gfx::VectorIconId GetVectorIconId() const override;

int GetIconId() const override;

@@ -34,8 +35,8 @@ class RegisterProtocolHandlerPermissionRequest

void PermissionDenied() override;

void Cancelled() override;

void RequestFinished() override;

+ PermissionBubbleType GetPermissionBubbleType() const override;

- private:

ProtocolHandlerRegistry* registry_;

ProtocolHandler handler_;

GURL origin_;