chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc - Issue 1884073002: Add a new metric for how many times permissions prompts are shown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc

Issue 1884073002: Add a new metric for how many times permissions prompts are shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/custom_handlers/register_protocol_handler_permission_request.h ('k') | chrome/browser/download/download_permission_request.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc

diff --git a/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc b/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc

index f1a54d14a7e73ea26876b0c0349c524f43381dc7..7f91ba839dab834ae06764ba1709621d3ca99ede 100644

--- a/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc

+++ b/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc

@@ -112,3 +112,8 @@ void RegisterProtocolHandlerPermissionRequest::Cancelled() {

void RegisterProtocolHandlerPermissionRequest::RequestFinished() {

delete this;

}

+PermissionBubbleType

+RegisterProtocolHandlerPermissionRequest::GetPermissionBubbleType() const {

+ return PermissionBubbleType::REGISTER_PROTOCOL_HANDLER;