third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html - Issue 1883873002: Do not block document.written scripts in page reloads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html

Issue 1883873002: Do not block document.written scripts in page reloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback incorporated. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/loading/doc-write-async-third-party-script.html ('k') | third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block-all-conn-types.html » ('j') | third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-reload.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html b/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html

index 355ba97e3bea70d945a2366db0ce7ad2a1b25ab6..8ee2dab97c76405162f9c2f41ea9cfed3598d13e 100644

--- a/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html

+++ b/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html

@@ -32,6 +32,7 @@

}, false);

}

+ filePath = '/loading/resources/js-loaded.js?same-origin';

src = sameOrigin + filePath;

jsLoaded = false;

loadSuccess = false;

@@ -49,6 +50,7 @@

var jsLoaded = false;

var loadSuccess = false;

+ var filePath = '/loading/resources/js-loaded.js';

jkarlin 2016/04/18 14:00:43 For consistency, it seems this one should be js-lo

shivanisha 2016/04/18 17:03:38 done.

src = crossOrigin + filePath;

document.write('<scr' + 'ipt src="' + src + '" onload="loadSuccess=true"></scr' + 'ipt>');

</script>

@@ -64,7 +66,7 @@

loadSuccess = false;

var loadFailed = false;

- filePath = '/loading/resources/js-loaded.js?1';

+ filePath = '/loading/resources/js-loaded.js?cross-origin';

jkarlin 2016/04/18 14:00:43 Perhaps cross-origin2?

shivanisha 2016/04/18 17:03:38 done.

src = crossOrigin + filePath;

document.write('<scr' + 'ipt src="' + src + '" onload="loadSuccess=true" onError="loadFailed=true"></scr' + 'ipt>');

</script>