third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html - Issue 1883873002: Do not block document.written scripts in page reloads

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html

Issue 1883873002: Do not block document.written scripts in page reloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback incorporated. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/loading/doc-write-async-third-party-script.html ('k') | third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block-all-conn-types.html » ('j') | third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-reload.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../resources/testharness.js"></script>	2 <script src="../resources/testharness.js"></script>

3 <script src="../resources/testharnessreport.js"></script>	3 <script src="../resources/testharnessreport.js"></script>

4 <script>	4 <script>

5 var sameOrigin = 'http://127.0.0.1:8000';	5 var sameOrigin = 'http://127.0.0.1:8000';

6 var crossOrigin = 'http://localhost:8000';	6 var crossOrigin = 'http://localhost:8000';

7 var filePath = '/loading/resources/js-loaded.js';	7 var filePath = '/loading/resources/js-loaded.js';

8 var jsLoaded = false;	8 var jsLoaded = false;

9 var loadSuccess = false;	9 var loadSuccess = false;

10	10

(...skipping 14 matching lines...) Expand all Loading...
25 internals.setNetworkConnectionInfo('cellular2g', 1.0);	25 internals.setNetworkConnectionInfo('cellular2g', 1.0);

26 internals.evictAllResources();	26 internals.evictAllResources();

27	27

28 // Reset the state of the singleton network state notifier.	28 // Reset the state of the singleton network state notifier.

29 window.addEventListener('beforeunload', function() {	29 window.addEventListener('beforeunload', function() {

30 internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrameOn SlowConnections(false);	30 internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrameOn SlowConnections(false);

31 internals.setNetworkStateNotifierTestOnly(false);	31 internals.setNetworkStateNotifierTestOnly(false);

32 }, false);	32 }, false);

33 }	33 }

34	34

	35 filePath = '/loading/resources/js-loaded.js?same-origin';

35 src = sameOrigin + filePath;	36 src = sameOrigin + filePath;

36 jsLoaded = false;	37 jsLoaded = false;

37 loadSuccess = false;	38 loadSuccess = false;

38 document.write('<scr' + 'ipt src="' + src + '" onload="loadSuccess=true"></s cr' + 'ipt>');	39 document.write('<scr' + 'ipt src="' + src + '" onload="loadSuccess=true"></s cr' + 'ipt>');

39 </script>	40 </script>

40	41

41 <script>	42 <script>

42 test(function () {	43 test(function () {

43 assert_true(jsLoaded);	44 assert_true(jsLoaded);

44 assert_true(loadSuccess);	45 assert_true(loadSuccess);

45 }, "Same domain doc.written scripts are not blocked");	46 }, "Same domain doc.written scripts are not blocked");

46 </script>	47 </script>

47	48

48 <script>	49 <script>

49 var jsLoaded = false;	50 var jsLoaded = false;

50 var loadSuccess = false;	51 var loadSuccess = false;

51	52

	53 var filePath = '/loading/resources/js-loaded.js';
	jkarlin 2016/04/18 14:00:43 For consistency, it seems this one should be js-lo For consistency, it seems this one should be js-loaded.js?cross-origin and the one below js-loaded.js?cross-origin2 shivanisha 2016/04/18 17:03:38 done. Show quoted text On 2016/04/18 at 14:00:43, jkarlin wrote: > For consistency, it seems this one should be js-loaded.js?cross-origin and the one below js-loaded.js?cross-origin2 done.
52 src = crossOrigin + filePath;	54 src = crossOrigin + filePath;

53 document.write('<scr' + 'ipt src="' + src + '" onload="loadSuccess=true"></s cr' + 'ipt>');	55 document.write('<scr' + 'ipt src="' + src + '" onload="loadSuccess=true"></s cr' + 'ipt>');

54 </script>	56 </script>

55	57

56 <script>	58 <script>

57 test(function () {	59 test(function () {

58 assert_true(jsLoaded);	60 assert_true(jsLoaded);

59 assert_true(loadSuccess);	61 assert_true(loadSuccess);

60 }, "cross-origin script not blocked since it is cached");	62 }, "cross-origin script not blocked since it is cached");

61 </script>	63 </script>

62 <script>	64 <script>

63 jsLoaded = false;	65 jsLoaded = false;

64 loadSuccess = false;	66 loadSuccess = false;

65 var loadFailed = false;	67 var loadFailed = false;

66	68

67 filePath = '/loading/resources/js-loaded.js?1';	69 filePath = '/loading/resources/js-loaded.js?cross-origin';
	jkarlin 2016/04/18 14:00:43 Perhaps cross-origin2? Perhaps cross-origin2? shivanisha 2016/04/18 17:03:38 done. Show quoted text On 2016/04/18 at 14:00:43, jkarlin wrote: > Perhaps cross-origin2? done.
68 src = crossOrigin + filePath;	70 src = crossOrigin + filePath;

69 document.write('<scr' + 'ipt src="' + src + '" onload="loadSuccess=true" onE rror="loadFailed=true"></scr' + 'ipt>');	71 document.write('<scr' + 'ipt src="' + src + '" onload="loadSuccess=true" onE rror="loadFailed=true"></scr' + 'ipt>');

70 </script>	72 </script>

71	73

72 <script>	74 <script>

73 test(function () {	75 test(function () {

74 assert_false(jsLoaded);	76 assert_false(jsLoaded);

75 assert_false(loadSuccess);	77 assert_false(loadSuccess);

76 assert_true(loadFailed);	78 assert_true(loadFailed);

77 }, "cross origin doc.written scripts are blocked");	79 }, "cross origin doc.written scripts are blocked");

78 </script>	80 </script>

OLD	NEW