Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1883663005: Remove remaining binding layer RawPtr<>s. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove remaining binding layer RawPtr<>s. R=haraken BUG=585328 Committed: https://crrev.com/1fd85f6c776042f41ab020a73404664723ab0b05 Cr-Commit-Position: refs/heads/master@{#387278}

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -82 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/CustomElementConstructorBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScheduledAction.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptEventListener.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptEventListener.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ToV8.h View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.h View 4 chunks +1 line, -19 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8EventListener.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_types.py View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/methods.cpp View 2 chunks +1 line, -12 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/ElementFactory.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
sof
please take a look.
4 years, 8 months ago (2016-04-14 08:55:24 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-14 08:55:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883663005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883663005/20001
4 years, 8 months ago (2016-04-14 09:56:25 UTC) #7
sof
With this in place, I will followup & remove RawPtr.h
4 years, 8 months ago (2016-04-14 09:56:35 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-14 10:51:54 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 10:53:00 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1fd85f6c776042f41ab020a73404664723ab0b05
Cr-Commit-Position: refs/heads/master@{#387278}

Powered by Google App Engine
This is Rietveld 408576698