third_party/WebKit/Source/bindings/scripts/v8_types.py - Issue 1883663005: Remove remaining binding layer RawPtr<>s.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_types.py

Issue 1883663005: Remove remaining binding layer RawPtr<>s. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_types.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_types.py b/third_party/WebKit/Source/bindings/scripts/v8_types.py

index dc18cf246643ba8fa23fbe66bbbaaa04d0cd94c8..a7b97cee8ed012d253570a0541678b76bc4f6434 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_types.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_types.py

@@ -111,6 +111,7 @@ CPP_SPECIAL_CONVERSION_RULES = {

'Date': 'double',

'Dictionary': 'Dictionary',

'EventHandler': 'EventListener*',

+ 'EventListener': 'EventListener*',

'NodeFilter': 'NodeFilter*',

'Promise': 'ScriptPromise',

'ScriptValue': 'ScriptValue',

@@ -179,7 +180,7 @@ def cpp_type(idl_type, extended_attributes=None, raw_type=False, used_as_rvalue_

if base_idl_type in CPP_SPECIAL_CONVERSION_RULES:

return CPP_SPECIAL_CONVERSION_RULES[base_idl_type]

- if base_idl_type in NON_WRAPPER_TYPES:

+ if base_idl_type == 'SerializedScriptValue':

return ('PassRefPtr<%s>' if used_as_rvalue_type else 'RefPtr<%s>') % base_idl_type

if idl_type.is_string_type:

if not raw_type: