Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Issue 1883593004: GN: Use std::unique_ptr for owned pointers in VisualStudioWriter. (Closed)

Created:
4 years, 8 months ago by jbroman
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Use std::unique_ptr for owned pointers in VisualStudioWriter. BUG=602726 Committed: https://crrev.com/31500019dff1f12beb9731da14db3820cba2b991 Cr-Commit-Position: refs/heads/master@{#388031}

Patch Set 1 #

Patch Set 2 : fix bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -51 lines) Patch
M tools/gn/visual_studio_writer.h View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/gn/visual_studio_writer.cc View 1 11 chunks +31 lines, -27 lines 0 comments Download
M tools/gn/visual_studio_writer_unittest.cc View 5 chunks +22 lines, -22 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883593004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883593004/1
4 years, 8 months ago (2016-04-18 18:11:42 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/212976)
4 years, 8 months ago (2016-04-18 18:28:05 UTC) #4
jbroman
4 years, 8 months ago (2016-04-18 19:10:36 UTC) #8
brettw
lgtm
4 years, 8 months ago (2016-04-18 19:34:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883593004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883593004/20001
4 years, 8 months ago (2016-04-18 21:17:42 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-18 21:22:28 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 21:24:14 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/31500019dff1f12beb9731da14db3820cba2b991
Cr-Commit-Position: refs/heads/master@{#388031}

Powered by Google App Engine
This is Rietveld 408576698