Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: tools/gn/visual_studio_writer.h

Issue 1883593004: GN: Use std::unique_ptr for owned pointers in VisualStudioWriter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix bug Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/visual_studio_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/visual_studio_writer.h
diff --git a/tools/gn/visual_studio_writer.h b/tools/gn/visual_studio_writer.h
index 5b578ed3cbab3b968672fc707ed60d0c0cf373e3..297189606ecd66e1bcc3da83e5ae85c8e87886c5 100644
--- a/tools/gn/visual_studio_writer.h
+++ b/tools/gn/visual_studio_writer.h
@@ -6,6 +6,7 @@
#define TOOLS_GN_VISUAL_STUDIO_WRITER_H_
#include <iosfwd>
+#include <memory>
#include <string>
#include <vector>
@@ -77,8 +78,8 @@ class VisualStudioWriter {
std::string config_platform;
};
- using SolutionProjects = std::vector<SolutionProject*>;
- using SolutionFolders = std::vector<SolutionEntry*>;
+ using SolutionProjects = std::vector<std::unique_ptr<SolutionProject>>;
+ using SolutionFolders = std::vector<std::unique_ptr<SolutionEntry>>;
VisualStudioWriter(const BuildSettings* build_settings,
const char* config_platform,
« no previous file with comments | « no previous file | tools/gn/visual_studio_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698