Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 1883473002: arc: Support more types of notifications. (Closed)

Created:
4 years, 8 months ago by yoshiki
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Support more types of notifications. These patches add a support of InboxStyle and BigPictureStyle notifications. Related CLs: - http://crrev.com/1883473002 (Chromium side change, this patch) - ag/923744 (mojom change) - ag/923745 (Android side change) Bug=b/28027339 Committed: https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1 Cr-Commit-Position: refs/heads/master@{#391275}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comment #

Patch Set 3 : Fix build failure #

Total comments: 14

Patch Set 4 #

Total comments: 2

Patch Set 5 : Addressed comments #

Patch Set 6 : Rebased #

Total comments: 4

Patch Set 7 : Addressed comments #

Total comments: 4

Patch Set 8 : Addressed comments #

Patch Set 9 : Fix build failure #

Total comments: 2

Patch Set 10 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -12 lines) Patch
M components/arc.gypi View 1 2 3 4 5 6 7 8 9 3 chunks +4 lines, -0 lines 0 comments Download
M components/arc/BUILD.gn View 1 2 3 4 5 6 7 8 9 3 chunks +4 lines, -0 lines 0 comments Download
M components/arc/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
A components/arc/bitmap/bitmap_type_converters.h View 1 2 3 4 5 6 1 chunk +20 lines, -0 lines 0 comments Download
A components/arc/bitmap/bitmap_type_converters.cc View 1 2 3 4 5 6 7 8 1 chunk +36 lines, -0 lines 0 comments Download
A + components/arc/common/bitmap.mojom View 1 2 3 4 5 6 7 8 9 1 chunk +5 lines, -3 lines 0 comments Download
M components/arc/common/notifications.mojom View 1 2 3 4 5 4 chunks +9 lines, -2 lines 0 comments Download
M ui/arc/notification/arc_notification_item.cc View 1 2 3 4 5 6 7 8 9 4 chunks +80 lines, -5 lines 0 comments Download
M ui/message_center/message_center_style.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 40 (14 generated)
yoshiki
dcheng@, PTAL at mojom change? hidehiko@, PTAL at arc notification change? Thanks.
4 years, 8 months ago (2016-04-12 06:34:00 UTC) #6
hidehiko
On 2016/04/12 06:34:00, yoshiki wrote: > dcheng@, PTAL at mojom change? > hidehiko@, PTAL at ...
4 years, 8 months ago (2016-04-13 21:12:34 UTC) #7
hidehiko
On 2016/04/13 21:12:34, hidehiko wrote: > On 2016/04/12 06:34:00, yoshiki wrote: > > dcheng@, PTAL ...
4 years, 8 months ago (2016-04-13 21:13:16 UTC) #8
dcheng
https://codereview.chromium.org/1883473002/diff/40001/components/arc/common/notifications.mojom File components/arc/common/notifications.mojom (right): https://codereview.chromium.org/1883473002/diff/40001/components/arc/common/notifications.mojom#newcode28 components/arc/common/notifications.mojom:28: MAX = LIST I don't think MAX serves a ...
4 years, 8 months ago (2016-04-13 23:55:20 UTC) #9
yoshiki
hidehiko@, dcheng@, PTAL. https://codereview.chromium.org/1883473002/diff/40001/components/arc/common/notifications.mojom File components/arc/common/notifications.mojom (right): https://codereview.chromium.org/1883473002/diff/40001/components/arc/common/notifications.mojom#newcode28 components/arc/common/notifications.mojom:28: MAX = LIST On 2016/04/13 23:55:20, ...
4 years, 8 months ago (2016-04-15 00:32:34 UTC) #11
hidehiko
https://codereview.chromium.org/1883473002/diff/100001/components/arc/BUILD.gn File components/arc/BUILD.gn (right): https://codereview.chromium.org/1883473002/diff/100001/components/arc/BUILD.gn#newcode67 components/arc/BUILD.gn:67: "//skia", Is this needs to be in .gyp, too? ...
4 years, 8 months ago (2016-04-15 07:09:10 UTC) #12
yoshiki
PTAL. Thanks. https://codereview.chromium.org/1883473002/diff/100001/components/arc/BUILD.gn File components/arc/BUILD.gn (right): https://codereview.chromium.org/1883473002/diff/100001/components/arc/BUILD.gn#newcode67 components/arc/BUILD.gn:67: "//skia", On 2016/04/15 07:09:09, hidehiko wrote: > ...
4 years, 8 months ago (2016-04-15 14:36:39 UTC) #13
yoshiki
Hidehiko-san, ping.
4 years, 8 months ago (2016-04-18 17:41:54 UTC) #14
hidehiko
Oops, sorry for delay. https://codereview.chromium.org/1883473002/diff/100001/components/arc/BUILD.gn File components/arc/BUILD.gn (right): https://codereview.chromium.org/1883473002/diff/100001/components/arc/BUILD.gn#newcode67 components/arc/BUILD.gn:67: "//skia", On 2016/04/15 14:36:38, yoshiki ...
4 years, 8 months ago (2016-04-18 17:54:41 UTC) #15
yoshiki
Hidehiko-san, PTAL https://codereview.chromium.org/1883473002/diff/100001/components/arc/BUILD.gn File components/arc/BUILD.gn (right): https://codereview.chromium.org/1883473002/diff/100001/components/arc/BUILD.gn#newcode67 components/arc/BUILD.gn:67: "//skia", On 2016/04/18 17:54:41, hidehiko wrote: > ...
4 years, 8 months ago (2016-04-18 19:21:23 UTC) #16
hidehiko
https://codereview.chromium.org/1883473002/diff/160001/ui/arc/notification/arc_notification_item.cc File ui/arc/notification/arc_notification_item.cc (right): https://codereview.chromium.org/1883473002/diff/160001/ui/arc/notification/arc_notification_item.cc#newcode162 ui/arc/notification/arc_notification_item.cc:162: case ArcNotificationType::LIST: Please add "mojom::" https://codereview.chromium.org/1883473002/diff/160001/ui/arc/notification/arc_notification_item.cc#newcode187 ui/arc/notification/arc_notification_item.cc:187: case ArcNotificationType::IMAGE: ...
4 years, 8 months ago (2016-04-18 19:24:44 UTC) #17
yoshiki
Hidehiko-san, PTAL. Thanks. https://codereview.chromium.org/1883473002/diff/160001/ui/arc/notification/arc_notification_item.cc File ui/arc/notification/arc_notification_item.cc (right): https://codereview.chromium.org/1883473002/diff/160001/ui/arc/notification/arc_notification_item.cc#newcode162 ui/arc/notification/arc_notification_item.cc:162: case ArcNotificationType::LIST: On 2016/04/18 19:24:44, hidehiko ...
4 years, 8 months ago (2016-04-18 19:46:35 UTC) #19
hidehiko
components/arc LGTM.
4 years, 8 months ago (2016-04-18 21:30:49 UTC) #20
yoshiki
PTAL @dcheng, IPC (mojom) stuff. @reed, dependency to third_party/skia. @dewittj, change in ui/message_center/*.
4 years, 8 months ago (2016-04-19 02:34:30 UTC) #22
dewittj
message_center lgtm
4 years, 8 months ago (2016-04-19 17:11:19 UTC) #23
yoshiki
reed@, dcheng@, ping? dcheng: IPC (mojom) stuff. reed: dependency to third_party/skia.
4 years, 8 months ago (2016-04-20 03:49:41 UTC) #24
reed1
skia lgtm
4 years, 8 months ago (2016-04-20 13:19:57 UTC) #26
yoshiki
dcheng@, PTAL.
4 years, 8 months ago (2016-04-26 02:53:24 UTC) #27
dcheng
https://codereview.chromium.org/1883473002/diff/200001/components/arc/bitmap/bitmap_type_converters.cc File components/arc/bitmap/bitmap_type_converters.cc (right): https://codereview.chromium.org/1883473002/diff/200001/components/arc/bitmap/bitmap_type_converters.cc#newcode17 components/arc/bitmap/bitmap_type_converters.cc:17: SkImageInfo::Make(arcBitmap->width, arcBitmap->height, I'd suggest something more like this (since ...
4 years, 8 months ago (2016-04-27 01:04:10 UTC) #28
yoshiki
dcheng@, PTAL. Thanks. https://codereview.chromium.org/1883473002/diff/200001/components/arc/bitmap/bitmap_type_converters.cc File components/arc/bitmap/bitmap_type_converters.cc (right): https://codereview.chromium.org/1883473002/diff/200001/components/arc/bitmap/bitmap_type_converters.cc#newcode17 components/arc/bitmap/bitmap_type_converters.cc:17: SkImageInfo::Make(arcBitmap->width, arcBitmap->height, On 2016/04/27 01:04:09, dcheng ...
4 years, 7 months ago (2016-04-28 18:43:21 UTC) #29
dcheng
https://codereview.chromium.org/1883473002/diff/240001/components/arc/bitmap/bitmap_type_converters.cc File components/arc/bitmap/bitmap_type_converters.cc (right): https://codereview.chromium.org/1883473002/diff/240001/components/arc/bitmap/bitmap_type_converters.cc#newcode9 components/arc/bitmap/bitmap_type_converters.cc:9: SkBitmap TypeConverter<SkBitmap, arc::mojom::ArcBitmapPtr>::Convert( I worked on Mojo documentation this ...
4 years, 7 months ago (2016-04-29 23:39:32 UTC) #30
yoshiki
dcheng@, PTAL. https://codereview.chromium.org/1883473002/diff/240001/components/arc/bitmap/bitmap_type_converters.cc File components/arc/bitmap/bitmap_type_converters.cc (right): https://codereview.chromium.org/1883473002/diff/240001/components/arc/bitmap/bitmap_type_converters.cc#newcode9 components/arc/bitmap/bitmap_type_converters.cc:9: SkBitmap TypeConverter<SkBitmap, arc::mojom::ArcBitmapPtr>::Convert( On 2016/04/29 23:39:32, dcheng ...
4 years, 7 months ago (2016-05-02 09:14:57 UTC) #32
dcheng
lgtm
4 years, 7 months ago (2016-05-03 06:15:56 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883473002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883473002/280001
4 years, 7 months ago (2016-05-03 16:17:03 UTC) #36
commit-bot: I haz the power
Committed patchset #10 (id:280001)
4 years, 7 months ago (2016-05-03 17:16:50 UTC) #38
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 17:18:09 UTC) #40
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/4e040e320c7a55f4d72e406e2f78bbcb5cb5ccc1
Cr-Commit-Position: refs/heads/master@{#391275}

Powered by Google App Engine
This is Rietveld 408576698