arc: Support more types of notifications.

ui/message_center/message_center_style.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_MESSAGE_CENTER_MESSAGE_CENTER_STYLE_H_
 #define UI_MESSAGE_CENTER_MESSAGE_CENTER_STYLE_H_
 
 #include <stddef.h>
 
 #include "build/build_config.h"
@@ skipping 60 matching lines @@
 
 // Text sizes.
 const int kTitleFontSize = 14;             // For title only.
 const int kEmptyCenterFontSize = 13;       // For empty message only.
 const int kTitleLineHeight = 20;           // In DIPs.
 const int kMessageFontSize = 12;           // For everything but title.
 const int kMessageLineHeight = 18;         // In DIPs.
 
 // Colors.
 extern const SkColor kNotificationBackgroundColor; // Background of the card.
-extern const SkColor kImageBackgroundColor;        // Background of the image.
+MESSAGE_CENTER_EXPORT extern const SkColor
+    kImageBackgroundColor;        // Background of the image.

[dcheng, 2016/04/27 01:04:09]

I'd suggest moving this comment to before this line to avoid this funny
indenting.

(Also, not necessary for this CL, but why don't we just inline the colors in the
header file? SkColor is just a uint32. It'll reduce the clunkiness of having to
use the EXPORT macros)

[yoshiki, 2016/04/28 18:43:21]

Done.
Let me fix these extern'd SkColors in a separated patch.

 extern const SkColor kIconBackgroundColor;         // Used behind icons smaller
                                                    // than the icon view.
 extern const SkColor kRegularTextColor;            // Title, message, ...
 extern const SkColor kDimTextColor;
 extern const SkColor kFocusBorderColor;  // The focus border.
 MESSAGE_CENTER_EXPORT extern const SkColor
     kSmallImageMaskForegroundColor;  // Foreground of small icon image.
 MESSAGE_CENTER_EXPORT extern const SkColor
     kSmallImageMaskBackgroundColor;  // Background of small icon image.
 
 // Limits.
 
 // Given the size of an image, returns the size of the properly scaled-up image
 // which fits into |container_size|.
 MESSAGE_CENTER_EXPORT gfx::Size GetImageSizeForContainerSize(
     const gfx::Size& container_size,
     const gfx::Size& image_size);
 
 extern const int kNotificationMaximumImageHeight;  // For image notifications.
-extern const size_t kNotificationMaximumItems;     // For list notifications.
+MESSAGE_CENTER_EXPORT extern const size_t
+    kNotificationMaximumItems;     // For list notifications.
 
 // Timing.
 extern const int kAutocloseDefaultDelaySeconds;
 extern const int kAutocloseHighPriorityDelaySeconds;
 extern const int kAutocloseWebPageDelaySeconds;
 
 // Buttons.
 const int kButtonHeight = 38;              // In DIPs.
 const int kButtonHorizontalPadding = 16;   // In DIPs.
 const int kButtonIconTopPadding = 11;      // In DIPs.
@@ skipping 29 matching lines @@
 
 extern const SkColor kShadowColor;           // Shadow in the tray.
 
 extern const SkColor kMessageCenterBackgroundColor;
 extern const SkColor kFooterDelimiterColor;  // Separator color for the tray.
 extern const SkColor kFooterTextColor;       // Text color for tray labels.
 
 }  // namespace message_center
 
 #endif  // UI_MESSAGE_CENTER_MESSAGE_CENTER_STYLE_H_