Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1883443003: [generators] Simplify %CreateJSGeneratorObject (Closed)

Created:
4 years, 8 months ago by neis
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[generators] Simplify %CreateJSGeneratorObject Instead of looking at the top JavaScriptFrame, take the needed information as arguments. This is in preparation of the new generators implementation. R=adamk@chromium.org, bmeurer@chromium.org BUG=v8:4907 LOG=n Committed: https://crrev.com/e298646be8f2de00e37dc43dad8968f269c9ce0f Cr-Commit-Position: refs/heads/master@{#35430}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add back initialization of continuation, just to be on the safe side. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M src/parsing/parser.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-generator.cc View 1 1 chunk +8 lines, -12 lines 0 comments Download
M test/cctest/test-ast-expression-visitor.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
neis
4 years, 8 months ago (2016-04-12 09:21:11 UTC) #1
Benedikt Meurer
LGTM with nit. https://codereview.chromium.org/1883443003/diff/1/src/runtime/runtime-generator.cc File src/runtime/runtime-generator.cc (right): https://codereview.chromium.org/1883443003/diff/1/src/runtime/runtime-generator.cc#newcode17 src/runtime/runtime-generator.cc:17: DCHECK(args.length() == 2); Nit: DCHECK_EQ(2, args.length())
4 years, 8 months ago (2016-04-12 12:57:03 UTC) #2
adamk
lgtm I would suggest filing a tracking bug to track work on the new generators ...
4 years, 8 months ago (2016-04-12 18:04:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883443003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883443003/20001
4 years, 8 months ago (2016-04-13 07:52:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 08:16:37 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 08:18:26 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e298646be8f2de00e37dc43dad8968f269c9ce0f
Cr-Commit-Position: refs/heads/master@{#35430}

Powered by Google App Engine
This is Rietveld 408576698