Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: src/runtime/runtime-generator.cc

Issue 1883443003: [generators] Simplify %CreateJSGeneratorObject (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add back initialization of continuation, just to be on the safe side. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime.h ('k') | test/cctest/test-ast-expression-visitor.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/factory.h" 8 #include "src/factory.h"
9 #include "src/frames-inl.h" 9 #include "src/frames-inl.h"
10 #include "src/objects-inl.h" 10 #include "src/objects-inl.h"
11 11
12 namespace v8 { 12 namespace v8 {
13 namespace internal { 13 namespace internal {
14 14
15 RUNTIME_FUNCTION(Runtime_CreateJSGeneratorObject) { 15 RUNTIME_FUNCTION(Runtime_CreateJSGeneratorObject) {
16 HandleScope scope(isolate); 16 HandleScope scope(isolate);
17 DCHECK(args.length() == 0); 17 DCHECK(args.length() == 2);
18 18 CONVERT_ARG_HANDLE_CHECKED(JSFunction, function, 0);
19 JavaScriptFrameIterator it(isolate); 19 CONVERT_ARG_HANDLE_CHECKED(Object, receiver, 1);
20 JavaScriptFrame* frame = it.frame();
21 Handle<JSFunction> function(frame->function());
22 RUNTIME_ASSERT(function->shared()->is_generator()); 20 RUNTIME_ASSERT(function->shared()->is_generator());
23 21
24 Handle<JSGeneratorObject> generator; 22 Handle<JSGeneratorObject> generator =
25 DCHECK(!frame->IsConstructor()); 23 isolate->factory()->NewJSGeneratorObject(function);
26 generator = isolate->factory()->NewJSGeneratorObject(function);
27 generator->set_function(*function); 24 generator->set_function(*function);
28 generator->set_context(Context::cast(frame->context())); 25 generator->set_context(isolate->context());
29 generator->set_receiver(frame->receiver()); 26 generator->set_receiver(*receiver);
30 generator->set_continuation(0);
31 generator->set_operand_stack(isolate->heap()->empty_fixed_array()); 27 generator->set_operand_stack(isolate->heap()->empty_fixed_array());
32 28 generator->set_continuation(JSGeneratorObject::kGeneratorExecuting);
33 return *generator; 29 return *generator;
34 } 30 }
35 31
36 32
37 RUNTIME_FUNCTION(Runtime_SuspendJSGeneratorObject) { 33 RUNTIME_FUNCTION(Runtime_SuspendJSGeneratorObject) {
38 HandleScope handle_scope(isolate); 34 HandleScope handle_scope(isolate);
39 DCHECK(args.length() == 1); 35 DCHECK(args.length() == 1);
40 CONVERT_ARG_HANDLE_CHECKED(JSGeneratorObject, generator_object, 0); 36 CONVERT_ARG_HANDLE_CHECKED(JSGeneratorObject, generator_object, 0);
41 37
42 JavaScriptFrameIterator stack_iterator(isolate); 38 JavaScriptFrameIterator stack_iterator(isolate);
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 int offset = generator->continuation(); 129 int offset = generator->continuation();
134 RUNTIME_ASSERT(0 <= offset && offset < code->instruction_size()); 130 RUNTIME_ASSERT(0 <= offset && offset < code->instruction_size());
135 return Smi::FromInt(code->SourcePosition(offset)); 131 return Smi::FromInt(code->SourcePosition(offset));
136 } 132 }
137 133
138 return isolate->heap()->undefined_value(); 134 return isolate->heap()->undefined_value();
139 } 135 }
140 136
141 } // namespace internal 137 } // namespace internal
142 } // namespace v8 138 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime.h ('k') | test/cctest/test-ast-expression-visitor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698