Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1883423002: [Android,MediaRouter,Cast] implement onterminate and onclose. (Closed)

Created:
4 years, 8 months ago by whywhat
Modified:
4 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, media-router+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android,MediaRouter,Cast] implement onterminate and onclose. BUG=592732 TEST=e2e tests + MR instrumentation tests Committed: https://crrev.com/dd75c6ecf3b206cab118e8f38831101fb44fcc22 Cr-Commit-Position: refs/heads/master@{#387894}

Patch Set 1 #

Patch Set 2 : Enable more disabled tests #

Messages

Total messages: 13 (5 generated)
whywhat
Enable more disabled tests
4 years, 8 months ago (2016-04-15 14:01:21 UTC) #1
whywhat
PTaL
4 years, 8 months ago (2016-04-15 14:03:09 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883423002/20001
4 years, 8 months ago (2016-04-15 14:03:23 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 14:43:47 UTC) #7
Zhiqiang Zhang (Slow)
LGTM. Please make sure you call onRouteRequestError(), on RouteClosed() and onRouteClosedWithError() correctly.
4 years, 8 months ago (2016-04-15 18:47:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883423002/20001
4 years, 8 months ago (2016-04-18 11:38:08 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-18 12:16:37 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 12:18:01 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dd75c6ecf3b206cab118e8f38831101fb44fcc22
Cr-Commit-Position: refs/heads/master@{#387894}

Powered by Google App Engine
This is Rietveld 408576698