Issue 1883423002: [Android,MediaRouter,Cast] implement onterminate and onclose.

Issue 1883423002: [Android,MediaRouter,Cast] implement onterminate and onclose. (Closed)

Created:
4 years, 8 months ago by whywhat

Modified:
4 years, 8 months ago

Reviewers:
Zhiqiang Zhang (Slow), mlamouri (slow - plz ping)

CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, media-router+watch_chromium.org, posciak+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Android,MediaRouter,Cast] implement onterminate and onclose. BUG=592732 TEST=e2e tests + MR instrumentation tests Committed: https://crrev.com/dd75c6ecf3b206cab118e8f38831101fb44fcc22 Cr-Commit-Position: refs/heads/master@{#387894}

Patch Set 1 #

Patch Set 2 : Enable more disabled tests #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -35 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaRouteManager.java	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java	View		5 chunks	+10 lines, -20 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MediaRouterIntegrationTest.java	View	1	4 chunks	+5 lines, -10 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MockMediaRouteProvider.java	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/media/android/router/media_router_android.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/media/android/router/media_router_android.cc	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 13 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883423002/20001

4 years, 8 months ago (2016-04-15 14:03:23 UTC) #5

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 8 months ago (2016-04-15 14:43:47 UTC) #7

Zhiqiang Zhang (Slow)

LGTM. Please make sure you call onRouteRequestError(), on RouteClosed() and onRouteClosedWithError() correctly.

4 years, 8 months ago (2016-04-15 18:47:45 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883423002/20001

4 years, 8 months ago (2016-04-18 11:38:08 UTC) #10

commit-bot: I haz the power

4 years, 8 months ago (2016-04-18 12:18:01 UTC) #13

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/dd75c6ecf3b206cab118e8f38831101fb44fcc22
Cr-Commit-Position: refs/heads/master@{#387894}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages