chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MockMediaRouteProvider.java - Issue 1883423002: [Android,MediaRouter,Cast] implement onterminate and onclose.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MockMediaRouteProvider.java

Issue 1883423002: [Android,MediaRouter,Cast] implement onterminate and onclose. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Enable more disabled tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MediaRouterIntegrationTest.java ('k') | chrome/browser/media/android/router/media_router_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MockMediaRouteProvider.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MockMediaRouteProvider.java b/chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MockMediaRouteProvider.java

index da6ab42055165cbbc03565b6ae5b8e552c0d911b..b567ee13ebe10b7fa8b9eeb4a0d79d569b0111db 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MockMediaRouteProvider.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MockMediaRouteProvider.java

@@ -175,9 +175,7 @@ public class MockMediaRouteProvider implements MediaRouteProvider {

@Override

public void sendStringMessage(String routeId, String message, int nativeCallbackId) {

if (mCloseRouteWithErrorOnSend) {

- // TODO(zqzhang): The method need to notify the router that the connection state has

- // changed, so PresentationConnection.onclose will be called. See

- // http://crbug.com/592732

+ mManager.onRouteClosedWithError(routeId, "Sending message failed. Closing the route.");

} else {

// Sending a string enclosed by double quotes to behave like JSON.stringify().

mManager.onMessage(routeId, "\"" + "Pong: " + message + "\"");